GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Inter font and update packages by iggy890 · Pull Request #33 · CodeEditApp/codeedit.app

Conversation

@iggy890

@iggy890 iggy890 commented Mar 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This PR closes this issue by changing the SF Pro Text font to the Inter font.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iggy890
Add Inter font
05be927
@vercel

vercel Bot commented Mar 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
codeedit-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 9:18PM (UTC)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vercel
vercel Bot deployed to Preview March 3, 2023 17:11
View deployment
@austincondiff

austincondiff commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

You are not pulling in Inter. The way you have it, the user would need to have it installed on their system. We need to pull Inter in from Google Fonts. In order to do this, we need to do this how Next.js recommends you do it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iggy890
Update NextJS
29651c1
@vercel
vercel Bot deployed to Preview March 3, 2023 20:03
View deployment
@iggy890
Update fonts
d199819
@vercel
vercel Bot deployed to Preview March 3, 2023 20:06
View deployment
@iggy890
Finalize font
2f187f2
@vercel
vercel Bot deployed to Preview March 3, 2023 21:18
View deployment
@iggy890 iggy890 changed the title Add Inter font Add Inter font and update packages Mar 4, 2023
@noClaps

noClaps commented Jan 7, 2024

Copy link
Copy Markdown

You are not pulling in Inter. The way you have it, the user would need to have it installed on their system. We need to pull Inter in from Google Fonts. In order to do this, we need to do this how Next.js recommends you do it here.

Actually, the creator of Inter recommends against using Google Fonts since it doesn't have italics. The recommended way is to either self-host the files from Releases, or to use his CDN distribution.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch was successfully deployed

1 active deployment
Preview — 2f187f24 Deployed Mar 3, 2023 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Font choice

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iggy890 @austincondiff @noClaps
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.