GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: allow symfony 8 by W0rma · Pull Request #47 · Codeception/module-phpbrowser

Conversation

@W0rma

@W0rma W0rma commented Dec 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fixes #46

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mpesari, ThomasLandauer, and burned42 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@W0rma
W0rma force-pushed the symfony8 branch from 882914f to 274f1e1 Compare December 15, 2025 13:23
W0rma
W0rma commented Dec 15, 2025
View reviewed changes
Comment thread src/Codeception/Lib/Connector/Guzzle.php
}

protected function doRequest(object $request)
protected function doRequest(object $request): object

@W0rma W0rma Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type was added because it was added in symfony/browser-kit v8 as well.

This change could be considered a BC break.
The class is not final and thus users might get a type error if they extended this class and used a different return type.

@TavoNiievez @SamMousa What's your opinion here? Should this change be considered a BC break and thus result in a new major release?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@W0rma W0rma Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that #37 added some return type hints to some methods as well without tagging a new major version. The changes were part of the bugfix release 3.0.2.

Maybe it is okay to accept the BC break of my PR without tagging a new major version?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@TavoNiievez TavoNiievez Dec 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how major releases in repositories that have automated releases configured actually work.
I probably skipped checking whether this should be released as a minor or major change when I saw that the process was automated.
IMO, we should treat the release of this version as it was labeled as a mistake.
We should stick to semver as much as possible.
But I'll leave the final word to @SamMousa since he's a little more familiar with it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@W0rma W0rma Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how major releases in repositories that have automated releases configured actually work.

According to the docs to add "BREAKING CHANGE:" to the footer of the commit message.

I'm looking forward to the opinion of @SamMousa as well 😃

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@W0rma W0rma Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs to add "BREAKING CHANGE:" to the footer of the commit message.

Adjusting the commit message worked like a charm and https://github.com/Codeception/module-phpbrowser/releases/tag/4.0.0 was successfully released.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@W0rma
W0rma marked this pull request as ready for review December 15, 2025 14:34
@W0rma
feat: allow symfony 8
0c65e95
BREAKING CHANGE: The native object return type was added to the doRequest() method of the Guzzle connector.
That might break code extending from this class.
@W0rma
W0rma force-pushed the symfony8 branch from 274f1e1 to 0c65e95 Compare January 23, 2026 13:23
@W0rma
W0rma merged commit 495a2cf into Codeception:master Jan 23, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the released label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TavoNiievez TavoNiievez TavoNiievez left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Symfony 8 support

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@W0rma @TavoNiievez
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.