GeezerVison is showing github.com — support invite target users by AlexanderTPohl · Pull Request #2428 · DSharpPlus/DSharpPlus
Conversation
- This pull request was written by AI
- This pull request was assisted by AI, but you wrote the final code
- This pull request did not involve AI in any way
Summary
Implemented support for all invite target users endpoints
Details
Adds support for all target user endpoints and modified the CreateInvite endpoint to support the invite creation with target users.
The in the api requried csv file is created from IEnumerable<ulong> and deserialized to IReadOnlyList<ulong> to simplify usage.
Changes proposed
- MultipartRestRequest now supports to set the fieldname for files
- CreateChannelInvite supports the invite creation with Targetusers
- Added support for GetTargetUsers endpoint
- Added support for UpdateTargetUsers endpoint
- Added support for GetTargetUsersJobStatus endpoint
- Added utilities methods for creating and reading a csv stream
Notes
For the exceptions to work properly a fix for the issued adressed in #2426 is needed.
- All features in this pull request were tested.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please note that i wrote the suggested changes off memory in the github web UI, you should test whether they work (or come up with something similar, point is that target_users is intended for potentially very large collections and i would like the code to allocate less intermediary memory)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one review comment remains from my previous review (line splitting on DiscordChannel.CreateInviteAsync), rtm otherwise
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.