GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — + Read UnitSearchPath from DPROJ by Fr0sT-Brutal · Pull Request #8 · DelphiCodeCoverage/DelphiCodeCoverage

Conversation

@Fr0sT-Brutal

@Fr0sT-Brutal Fr0sT-Brutal commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

DCC_UnitSearchPath option of base config is used. Retrieving of base config node is extracted to function GetBasePropertyGroupNode

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fr0sT-Brutal
+ Read UnitSearchPath from DPROJ
6ab235f
@Laurensvanrun

Laurensvanrun commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Nice contribution. However, your are missing tests. Can you add these?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fr0sT-Brutal

Fr0sT-Brutal commented Aug 10, 2021

Copy link
Copy Markdown
Contributor Author

Done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fr0sT-Brutal
+ Add test
88045ae
@Fr0sT-Brutal
Fr0sT-Brutal force-pushed the feat_read-searchpath-from-dproj branch from db73812 to 88045ae Compare August 10, 2021 12:38
@Laurensvanrun
Laurensvanrun merged commit c83db22 into DelphiCodeCoverage:master Aug 10, 2021
@Fr0sT-Brutal
Fr0sT-Brutal deleted the feat_read-searchpath-from-dproj branch August 10, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fr0sT-Brutal @Laurensvanrun
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.