GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — TestCafe: rerun quarantined tests in their themes by EugeniyKiyashko · Pull Request #36172 · DevExpress/DevExtreme Conversation- quarantine.json entries take an optional "themes" list. Regular jobs skip such a test only in those themes and keep running it in the others. - The quarantine job reruns quarantined tests once per theme: entries without "themes" and unstable tests in fluent and fluent-next, entries with "themes" in the listed ones. Before, every quarantined test reran only in fluent, so a test that flaked in fluent-next lost its fluent-next coverage. - With --onlyQuarantined, runner.ts no longer keeps only theme-bound tests when a theme is passed without a component folder; the entry's themes decide.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Approval recommendedThere are no active review issues for the theme-aware quarantine rerun changes. No open issues 🎉 What changed in this PRThis PR makes TestCafe quarantine reruns theme-aware so quarantined tests run in their configured themes rather than a single default environment. Changes:
Review effort: Balanced
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
At least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |