GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Expand time API by Rollczi · Pull Request #55 · EternalCodeTeam/EternalCodeCommons

Conversation

@Rollczi

@Rollczi Rollczi commented Aug 16, 2025

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Rollczi
Expand time API
b15dab6
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 16, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Rollczi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the "TemporalAmountParser" class to enhance its time formatting capabilities by separating the logic of parsing temporal amounts from their string representation. It introduces new data structures, "TimePart" and "TimeResult", to encapsulate the components of a parsed temporal amount and its sign. This separation of concerns allows for more flexible handling and potential alternative representations of time durations beyond simple string formatting.

Highlights

  • Refactor TemporalAmountParser: The existing "format" method in "TemporalAmountParser" has been refactored. Its core logic for calculating time components and determining the sign is now encapsulated in a new "prepare" method, which returns a structured "TimeResult" object. The "format" method now consumes this "TimeResult" to produce the final string.
  • Introduce TimePart Record: A new Java record, "TimePart", has been introduced. This record is designed to hold a single component of a temporal amount, such as the numerical count (e.g., 30), its abbreviated name (e.g., "s" for seconds), and the corresponding "ChronoUnit".
  • Introduce TimeResult Record: A new Java record, "TimeResult", has been added. This record serves as a container for the output of the "prepare" method, holding a list of "TimePart" objects and a boolean flag indicating whether the original temporal amount was negative.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 16, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively expands the time API by separating the parsing logic from the formatting logic in TemporalAmountParser. The introduction of the prepare() method along with TimeResult and TimePart records is a great architectural improvement, making the API more flexible and reusable. My review includes a couple of suggestions: one to remove a redundant check for improved code clarity, and another to add unit tests for the new public prepare method to ensure its correctness and maintainability.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread eternalcode-commons-shared/src/main/java/com/eternalcode/commons/time/TemporalAmountParser.java
*/
public String format(T temporalAmount) {
StringBuilder builder = new StringBuilder();
public TimeResult prepare(T temporalAmount) {

@gemini-code-assist gemini-code-assist Bot Aug 16, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new public method prepare should have its own unit tests. While the existing tests for format will indirectly cover some of prepare's logic, they don't validate the structure of the returned TimeResult object (e.g., the isNegative flag, or the details of each TimePart). Adding dedicated tests for prepare would ensure its contract is met and prevent future regressions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread eternalcode-commons-shared/src/main/java/com/eternalcode/commons/time/TemporalAmountParser.java
Comment on lines +367 to +373
for (TimePart part : result.parts()) {
if (part.count().equals(BigInteger.ZERO)) {
continue;
}

builder.append(part.count()).append(part.name());
}

@gemini-code-assist gemini-code-assist Bot Aug 16, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This loop contains a redundant check. The prepare() method already filters out time parts with a zero count, so the if (part.count().equals(BigInteger.ZERO)) check is unnecessary. You can simplify the loop.

        for (TimePart part : result.parts()) {
            builder.append(part.count()).append(part.name());
        }

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jakubk15 Jakubk15 added the 🆕 feature New feature or request label Feb 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

🆕 feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Rollczi @Jakubk15
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.