GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Manage redis pipe's context (#3655) · ExpediaGroup/feast@48e0971

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

sdk/python/feast/infra/online_stores
- redis.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎sdk/python/feast/infra/online_stores/redis.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/online_stores/redis.py

+7-7Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -89,15 +89,15 @@ class RedisOnlineStore(OnlineStore):`
`89`	`89`	`def delete_entity_values(self, config: RepoConfig, join_keys: List[str]):`
`90`	`90`	`client = self._get_client(config.online_store)`
`91`	`91`	`deleted_count = 0`
`92`		`- pipeline = client.pipeline(transaction=False)`
`93`	`92`	`prefix = _redis_key_prefix(join_keys)`
`94`	`93`
`95`		`- for _k in client.scan_iter(`
`96`		`- b"".join([prefix, b"*", config.project.encode("utf8")])`
`97`		`- ):`
`98`		`- pipeline.delete(_k)`
`99`		`- deleted_count += 1`
`100`		`- pipeline.execute()`
	`94`	`+ with client.pipeline(transaction=False) as pipe:`
	`95`	`+ for _k in client.scan_iter(`
	`96`	`+ b"".join([prefix, b"*", config.project.encode("utf8")])`
	`97`	`+ ):`
	`98`	`+ pipe.delete(_k)`
	`99`	`+ deleted_count += 1`
	`100`	`+ pipe.execute()`
`101`	`101`
`102`	`102`	`logger.debug(f"Deleted {deleted_count} rows for entity {', '.join(join_keys)}")`
`103`	`103`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.