GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Add gunicorn for serve with multiprocess (#3636) · ExpediaGroup/feast@4de7faf

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

sdk/python
- feast
- requirements
setup.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎sdk/python/feast/cli.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/cli.py

+26-1Lines changed: 26 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -649,6 +649,21 @@ def init_command(project_directory, minimal: bool, template: str):`
`649`	`649`	`show_default=True,`
`650`	`650`	`help="Disable logging served features",`
`651`	`651`	`)`
	`652`	`+@click.option(`
	`653`	`+ "--workers",`
	`654`	`+ "-w",`
	`655`	`+ type=click.INT,`
	`656`	`+ default=1,`
	`657`	`+ show_default=True,`
	`658`	`+ help="Number of worker",`
	`659`	`+)`
	`660`	`+@click.option(`
	`661`	`+ "--keep-alive-timeout",`
	`662`	`+ type=click.INT,`
	`663`	`+ default=5,`
	`664`	`+ show_default=True,`
	`665`	`+ help="Timeout for keep alive",`
	`666`	`+)`
`652`	`667`	`@click.pass_context`
`653`	`668`	`def serve_command(`
`654`	`669`	`ctx: click.Context,`
`@@ -657,11 +672,21 @@ def serve_command(`
`657`	`672`	`type_: str,`
`658`	`673`	`no_access_log: bool,`
`659`	`674`	`no_feature_log: bool,`
	`675`	`+ workers: int,`
	`676`	`+ keep_alive_timeout: int,`
`660`	`677`	`):`
`661`	`678`	`"""Start a feature server locally on a given port."""`
`662`	`679`	`store = create_feature_store(ctx)`
`663`	`680`
`664`		`- store.serve(host, port, type_, no_access_log, no_feature_log)`
	`681`	`+ store.serve(`
	`682`	`+ host=host,`
	`683`	`+ port=port,`
	`684`	`+ type_=type_,`
	`685`	`+ no_access_log=no_access_log,`
	`686`	`+ no_feature_log=no_feature_log,`
	`687`	`+ workers=workers,`
	`688`	`+ keep_alive_timeout=keep_alive_timeout,`
	`689`	`+ )`
`665`	`690`
`666`	`691`
`667`	`692`	`@cli.command("serve_transformations")`

Collapse file

`‎sdk/python/feast/feature_server.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/feature_server.py

+31-4Lines changed: 31 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@`
`2`	`2`	`import traceback`
`3`	`3`	`import warnings`
`4`	`4`
	`5`	`+import gunicorn.app.base`
`5`	`6`	`import pandas as pd`
`6`		`-import uvicorn`
`7`	`7`	`from fastapi import FastAPI, HTTPException, Request, Response, status`
`8`	`8`	`from fastapi.logger import logger`
`9`	`9`	`from fastapi.params import Depends`
`@@ -137,8 +137,35 @@ def health():`
`137`	`137`	`return app`
`138`	`138`
`139`	`139`
	`140`	`+class FeastServeApplication(gunicorn.app.base.BaseApplication):`
	`141`	`+ def __init__(self, store: "feast.FeatureStore", **options):`
	`142`	`+ self._app = get_app(store=store)`
	`143`	`+ self._options = options`
	`144`	`+ super().__init__()`
	`145`	`+`
	`146`	`+ def load_config(self):`
	`147`	`+ for key, value in self._options.items():`
	`148`	`+ if key.lower() in self.cfg.settings and value is not None:`
	`149`	`+ self.cfg.set(key.lower(), value)`
	`150`	`+`
	`151`	`+ self.cfg.set("worker_class", "uvicorn.workers.UvicornWorker")`
	`152`	`+`
	`153`	`+ def load(self):`
	`154`	`+ return self._app`
	`155`	`+`
	`156`	`+`
`140`	`157`	`def start_server(`
`141`		`- store: "feast.FeatureStore", host: str, port: int, no_access_log: bool`
	`158`	`+ store: "feast.FeatureStore",`
	`159`	`+ host: str,`
	`160`	`+ port: int,`
	`161`	`+ no_access_log: bool,`
	`162`	`+ workers: int,`
	`163`	`+ keep_alive_timeout: int,`
`142`	`164`	`):`
`143`		`- app = get_app(store)`
`144`		`- uvicorn.run(app, host=host, port=port, access_log=(not no_access_log))`
	`165`	`+ FeastServeApplication(`
	`166`	`+ store=store,`
	`167`	`+ bind=f"{host}:{port}",`
	`168`	`+ accesslog=None if no_access_log else "-",`
	`169`	`+ workers=workers,`
	`170`	`+ keepalive=keep_alive_timeout,`
	`171`	`+ ).run()`

Collapse file

`‎sdk/python/feast/feature_store.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/feature_store.py

+10-2Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2152,7 +2152,6 @@ def _get_feature_views_to_use(`
`2152`	`2152`	`allow_cache=False,`
`2153`	`2153`	`hide_dummy_entity: bool = True,`
`2154`	`2154`	`) -> Tuple[List[FeatureView], List[RequestFeatureView], List[OnDemandFeatureView]]:`
`2155`		`-`
`2156`	`2155`	`fvs = {`
`2157`	`2156`	`fv.name: fv`
`2158`	`2157`	`for fv in [`
`@@ -2223,6 +2222,8 @@ def serve(`
`2223`	`2222`	`type_: str,`
`2224`	`2223`	`no_access_log: bool,`
`2225`	`2224`	`no_feature_log: bool,`
	`2225`	`+ workers: int,`
	`2226`	`+ keep_alive_timeout: int,`
`2226`	`2227`	`) -> None:`
`2227`	`2228`	`"""Start the feature consumption server locally on a given port."""`
`2228`	`2229`	`type_ = type_.lower()`
`@@ -2231,7 +2232,14 @@ def serve(`
`2231`	`2232`	`f"Python server only supports 'http'. Got '{type_}' instead."`
`2232`	`2233`	`)`
`2233`	`2234`	`# Start the python server`
`2234`		`- feature_server.start_server(self, host, port, no_access_log)`
	`2235`	`+ feature_server.start_server(`
	`2236`	`+ self,`
	`2237`	`+ host=host,`
	`2238`	`+ port=port,`
	`2239`	`+ no_access_log=no_access_log,`
	`2240`	`+ workers=workers,`
	`2241`	`+ keep_alive_timeout=keep_alive_timeout,`
	`2242`	`+ )`
`2235`	`2243`
`2236`	`2244`	`@log_exceptions_and_usage`
`2237`	`2245`	`def get_feature_server_endpoint(self) -> Optional[str]:`

Collapse file