GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support DraftRetriever datastore read/write for large vocab sizes (i.e. llama3+) and REST inference for llama3 by scandukuri · Pull Request #24 · FasterDecoding/REST

Conversation

@scandukuri

@scandukuri scandukuri commented Nov 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Here we make the necessary changes to read and write suffixes to memory and file for large tokenizers; the original implementation only supported token IDs up to Rust u16::MAX (65,535). Crucially, using Rust i32 for reading and writing individual token IDs (instead of u16 originally) allows the tool to support token IDs of up to Rust i32::MAX (2,147,483,647), and still allows negative placeholder IDs for padding in the implementation like -2.

We also make the necessary adjustments torest/modeling_llama_kv.py to support llama3 inference with REST, adapted from the transformers implementation. Importantly, we need to repeat_kv for new keys and values before concatenating them to cached keys and values, in order to avoid shape mismatches (by only adding a single query group to all cached keys and values).

Including the old PR here for reference. Thanks! 🦙

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
scandukuri added 4 commits November 12, 2024 22:30
@scandukuri
support large vocab sizes (i.e. llama3) for DraftRetriever datastore
05f57b0
@scandukuri
updates comments to explain implementation changes
9b9cebd
@scandukuri
modify modeling_llama_kv for llama3 compatibility
0be6495
@scandukuri
Merge remote-tracking branch 'upstream/main' into llama3
b15cc6c
@scandukuri

scandukuri commented Nov 20, 2024

Copy link
Copy Markdown
Author

@zhenyuhe00 Here's a new PR with a separate branch and added changes to modeling_llama_kv.py - it seems like the base branch may still be main, though. Do you know how I can PR my fork's llama3 changes to create a new llama3 branch in the original codebase?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zhenyuhe00

zhenyuhe00 commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Hi, I appreciate your effort! Since the repository only has the "main" branch, I added a new branch called "llama3" just now. It could be merged into the "llama3" branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zhenyuhe00
zhenyuhe00 changed the base branch from main to llama3 November 22, 2024 03:21
@zhenyuhe00
zhenyuhe00 merged commit ff9d5e4 into FasterDecoding:llama3 Nov 22, 2024
@zhenyuhe00 zhenyuhe00 mentioned this pull request Nov 22, 2024
Lama2 70B-chat is not supported? #22
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@scandukuri @zhenyuhe00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.