GeezerVison is showing github.com — Support DraftRetriever datastore read/write for large vocab sizes (i.e. llama3+) and REST inference for llama3 by scandukuri · Pull Request #24 · FasterDecoding/REST
Conversation
scandukuri
commented
Nov 20, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Here we make the necessary changes to read and write suffixes to memory and file for large tokenizers; the original implementation only supported token IDs up to Rust u16::MAX (65,535). Crucially, using Rust i32 for reading and writing individual token IDs (instead of u16 originally) allows the tool to support token IDs of up to Rust i32::MAX (2,147,483,647), and still allows negative placeholder IDs for padding in the implementation like -2.
We also make the necessary adjustments torest/modeling_llama_kv.py to support llama3 inference with REST, adapted from the transformers implementation. Importantly, we need to repeat_kv for new keys and values before concatenating them to cached keys and values, in order to avoid shape mismatches (by only adding a single query group to all cached keys and values).
Including the old PR here for reference. Thanks! 🦙
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@zhenyuhe00 Here's a new PR with a separate branch and added changes to modeling_llama_kv.py - it seems like the base branch may still be main, though. Do you know how I can PR my fork's llama3 changes to create a new llama3 branch in the original codebase?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hi, I appreciate your effort! Since the repository only has the "main" branch, I added a new branch called "llama3" just now. It could be merged into the "llama3" branch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.