GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correction of the return values of the DatabaseInfo methods for determining the insert, read and delete operations by DevM900 · Pull Request #1183 · FirebirdSQL/NETProvider

Conversation

@DevM900

@DevM900 DevM900 commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

These changes make it possible to analyze the performance of queries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mobeil1 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
DevM900 added 8 commits June 27, 2024 14:15
@DevM900
Creation of backup and restore statistics can be switched off to supp…
b492cce 
…ort Firebird Server 2.0.
@DevM900
Determination of the correct number of reads, inserts, deletes, etc. …
c39be07 
…per table since the last connection to the database
@DevM900
Determination of the correct number of reads, inserts, deletes, etc. …
1fd2464 
…per table since the last connection to the database.

fixes FirebirdSQL#1157
@DevM900
Added comments.
9112e28
@DevM900
Merge branch 'DatabaseInfo' of https://github.com/DevM900/NETProvider …
c00d785 
…into DatabaseInfo
@DevM900
Type of the key of the result collection changed from "uint" to "short".
124e5f3
@DevM900
Type of the key of the result collection changed from "uint" to "short".
c43a1bf
@DevM900
Added tests for determination of the number of reads, inserts, delete…
72ed318 
…s etc
cincuranet
cincuranet requested changes Aug 26, 2024
View reviewed changes
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();

var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection);

@cincuranet cincuranet Aug 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await using

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DevM900 DevM900 Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();

var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);

@cincuranet cincuranet Aug 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await using

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DevM900 DevM900 Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<string, short> tableNameList = GetTableNameList();
short tableIdTest = tableNameList["TEST"];

var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);

@cincuranet cincuranet Aug 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await using

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DevM900 DevM900 Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/IscHelper.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
if (counter > 0)
result.Add(keyValuePair.Key, counter);
}
else

@cincuranet cincuranet Aug 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add }/{ for consistency sake.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DevM900 DevM900 Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cincuranet cincuranet Nov 6, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cincuranet cincuranet added blocked/waiting and removed blocked/waiting labels Aug 26, 2024
DevM900 added 6 commits September 13, 2024 07:13
@DevM900
using await
aa0d9f7
@DevM900
changed to var
2acda4a
@DevM900
prefix on argument removed,
7edc7ee
@DevM900
extra spaces removed
367af06
@DevM900
'private' modifier removed
600fb37
@DevM900
prefix 'a' on arguments removed
3f1e72c
@DevM900
DevM900 requested a review from cincuranet September 13, 2024 09:10
@fdcastel

fdcastel commented Oct 25, 2024

Copy link
Copy Markdown
Member

@cincuranet it appears that all requested changes have been addressed by @DevM900 (but weren't marked as "resolved").

Could you please review and proceed with the merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DevM900
Merge remote-tracking branch 'upstream/master' into DatabaseInfo
a9311a0
cincuranet
cincuranet requested changes Nov 4, 2024
View reviewed changes
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cincuranet

cincuranet commented Nov 4, 2024

Copy link
Copy Markdown
Member

Not really. Some are still not addressed and going through it again I found some more.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DevM900 added 6 commits November 4, 2024 14:47
@DevM900
Typo statistic -> statistics
cef7087
@DevM900
removed not needed "using"
e720df4
@DevM900
changed to "var"
bf09d5a
@DevM900
Using async/await in "GetTableNameList"
fa0f53c
@DevM900
added “using” to ensure that resources are released
9470f22
@DevM900
moved "trim" to SQL
187ab1c
@DevM900 DevM900 closed this Nov 5, 2024
@DevM900 DevM900 reopened this Nov 5, 2024
cincuranet
cincuranet requested changes Nov 5, 2024
View reviewed changes
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();

var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection);

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();

var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
IDictionary<string, short> tableNameList = GetTableNameList();
short tableIdTest = tableNameList["TEST"];

var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs

private IDictionary<string, short> GetTableNameList()
{
IDictionary<string, short> result = new Dictionary<string, short>();

@cincuranet cincuranet Nov 5, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like it's here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DevM900
added missing async/await
fe4c525
cincuranet
cincuranet reviewed Nov 6, 2024
View reviewed changes
Comment thread src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
}

IDictionary<short, ulong> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter)
async Task<IDictionary<short, ulong>> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter)

@cincuranet cincuranet Nov 6, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Task?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cincuranet cincuranet cincuranet requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DevM900 @fdcastel @cincuranet
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.