GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support type mappings in NativeAOT compiled models. by niekschoemaker · Pull Request #1295 · FirebirdSQL/NETProvider

Conversation

@niekschoemaker

@niekschoemaker niekschoemaker commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

dotnet ef dbcontext optimize --nativeaot failed because the Firebird type mappings had no public static Default property. Every Fb*TypeMapping now has one.
The generated code recreates a mapping as Default.Clone(...) from the standard RelationalTypeMappingParameters only, so FbDateTimeTypeMapping, FbStringTypeMapping and FbTimeSpanTypeMapping additionally expose FbDbType and Clone(FbDbType), and the new FbCSharpRuntimeAnnotationCodeGenerator emits that Clone when the FbDbType differs from the one of Default (e.g. DATE vs TIMESTAMP, CHAR vs VARCHAR).

The solutions employed here follow the same approach as the postgresql provider. So the generation of the Clone method when the type mapping isn't the exact mapping from Default.

This code has been generated by AI, and was manually reviewed by me.

I think this also covers a small part of issue #1096, but only the part where precompiled queries and models from efcore will work.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@niekschoemaker @claude
Support type mappings in NativeAOT compiled models.
a16b873
dotnet ef dbcontext optimize --nativeaot failed because the Firebird type mappings had no public static Default property.
Every Fb*TypeMapping now has one. The generated code recreates a mapping as Default.Clone(...) from the standard
RelationalTypeMappingParameters only, so FbDateTimeTypeMapping, FbStringTypeMapping and FbTimeSpanTypeMapping
additionally expose FbDbType and Clone(FbDbType), and the new FbCSharpRuntimeAnnotationCodeGenerator emits that
Clone when the FbDbType differs from the one of Default (e.g. DATE vs TIMESTAMP, CHAR vs VARCHAR).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@niekschoemaker
niekschoemaker marked this pull request as ready for review November 4, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@niekschoemaker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.