GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix unresolved field assignment crash (#426) by GadiVenkatesh · Pull Request #1 · GadiVenkatesh/liquidjava

Conversation

@GadiVenkatesh

@GadiVenkatesh GadiVenkatesh commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes liquid-java#426.

When LiquidJava analyzes a field assignment whose declaration cannot be resolved, CtFieldReference.getDeclaration() may return null. The current implementation passes this null declaration to checkAssignment(), which eventually attempts to read its annotations and throws a NullPointerException.

This change adds a null check in the field-assignment visitor. If the field declaration is unavailable, the verifier skips refinement and ghost-field processing that require the declaration, avoiding the internal crash.

Changes

  • Add a null guard before processing unresolved field assignments.
  • Add a regression fixture reproducing the unresolved field-write scenario.
  • Add

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@GadiVenkatesh
Fix unresolved field assignment crash (liquid-java#426)
55e43e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Verifier crashes on an assignment to a field of a class that cannot be resolved

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@GadiVenkatesh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.