GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: serialize pydantic request bodies before passing to httpx json= by MCPVOT · Pull Request #2 · GoHighLevel/highlevel-api-python

Conversation

@MCPVOT

@MCPVOT MCPVOT commented Aug 9, 2026

Copy link
Copy Markdown

Problem

Generated service methods pass typed request DTOs (pydantic BaseModel) straight to httpx json=. httpx uses plain json.dumps (no default=), which cannot serialize BaseModel — every typed POST/PUT method (create_contact, update_contact, upsert_contact, create_note, add_tags, ...) crashes with TypeError before reaching the network. Only plain-dict bodies work.

Fix

  • New serialize_payload() in src/highlevel/utils/request_utils.py: model_dump(exclude_none=True) for BaseModel, recursive for dict/list, passthrough for primitives, None stays None.
  • Wrapped all 291 call sites across 42 service files; import updated identically everywhere.

Verification

  • py_compile clean on all 43 modified files
  • serialize_payload(CreateContactDtoV3(locationId, firstName, email, customFields=[{key: event_id, fieldValue: ...}])) → JSON-serializable dict with exact customFields shape preserved
  • Edge cases pass: None → None, dict → passthrough, list of models → list of dicts
  • No behavior change for existing dict-based callers (passthrough)

Impact

Unblocks every typed-body method in the SDK (the most common usage per the README). ~10 lines of real logic in one place.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MCPVOT
fix: serialize pydantic request bodies before passing to httpx json=
65dae3b
Generated service methods pass typed request DTOs (pydantic BaseModel) straight
to httpx json=, which cannot serialize them (TypeError: not JSON serializable)
— every typed POST/PUT method crashed before reaching the network. Only plain
dicts worked.

Add serialize_payload() to request_utils (model_dump(exclude_none=True), with
recursive handling for dicts/lists), and wrap the 291 call sites across 42
service files. Dicts and primitives pass through unchanged; None stays None.

Verified: py_compile clean on all files; serialize_payload(CreateContactDtoV3)
produces a JSON-serializable dict with the exact proven customFields shape
({key, fieldValue}); edge cases (None, dict, nested list) pass.
@MCPVOT
MCPVOT requested a review from a team August 9, 2026 18:31
orca-security-us[bot]
orca-security-us Bot reviewed Aug 9, 2026
View reviewed changes

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

At least 2 approving reviews are required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@MCPVOT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.