GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — fix: serialize pydantic request bodies before passing to httpx json= by MCPVOT · Pull Request #2 · GoHighLevel/highlevel-api-python ConversationProblemGenerated service methods pass typed request DTOs (pydantic BaseModel) straight to httpx Fix
Verification
ImpactUnblocks every typed-body method in the SDK (the most common usage per the README). ~10 lines of real logic in one place.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsGenerated service methods pass typed request DTOs (pydantic BaseModel) straight
to httpx json=, which cannot serialize them (TypeError: not JSON serializable)
— every typed POST/PUT method crashed before reaching the network. Only plain
dicts worked.
Add serialize_payload() to request_utils (model_dump(exclude_none=True), with
recursive handling for dicts/lists), and wrap the 291 call sites across 42
service files. Dicts and primitives pass through unchanged; None stays None.
Verified: py_compile clean on all files; serialize_payload(CreateContactDtoV3)
produces a JSON-serializable dict with the exact proven customFields shape
({key, fieldValue}); edge cases (None, dict, nested list) pass.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Orca Security Scan Summary
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersAt least 2 approving reviews are required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |