GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: adding support for Java25 tests to work properly in CI by maigovannon · Pull Request #10199 · GoogleCloudPlatform/java-docs-samples

Conversation

@maigovannon

@maigovannon maigovannon commented Nov 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

This is one of the changes from #10193

Checklist

  • I have followed Sample Format Guide
  • Please merge this PR for me once it is approved

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maigovannon
feat: adding support for Java25 tests to work properly in CI
6e15e8a
@maigovannon
maigovannon requested review from a team and yoshi-approver as code owners November 3, 2025 11:49
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Nov 3, 2025
@gemini-code-assist

gemini-code-assist Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Java 25 within the continuous integration environment. By updating the CI script to acknowledge Java 25 as a valid target version, it ensures that projects configured to compile against Java 25 can be tested and validated without encountering version-related failures in the CI pipeline. This is a foundational step towards broader compatibility with newer Java releases.

Highlights

  • CI Configuration: The .kokoro/tests/run_test_java.sh script has been updated to include Java 25 in the list of ALLOWED_VERSIONS. This change enables the CI system to properly recognize and validate projects targeting Java 25.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 3, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Java 25 to the CI process by updating the .kokoro/tests/run_test_java.sh script. The change correctly adds "25" to the list of allowed Java versions. The implementation is straightforward and I have no further feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maigovannon
maigovannon requested a review from iennae November 3, 2025 12:06
@maigovannon maigovannon mentioned this pull request Nov 3, 2025
Adding new Doc Samples for Java25 #10193
Closed
5 of 6 tasks
iennae
iennae requested changes Nov 4, 2025
View reviewed changes

@iennae iennae left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not supporting java25 infrastructure as far as I can tell in gcr.io/cloud-devrel-kokoro-resources/ yet.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iennae iennae iennae requested changes
@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@maigovannon @iennae
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.