GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support for direct calls to execute lambda functions and return their output (for py.tests) by random-element · Pull Request #35 · HDE/python-lambda-local

Conversation

@random-element

@random-element random-element commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

When writing py.tests for lambda functions that have a non-empty return, each test function should create a test event/context, execute the lambda with the event/context and then compare the output of the function with the expected output.

This is currently not possible with the package as the command-line is its only interface.

This PR adds the feature for py.test functions (or any other module for that matter) to execute the lambda locally, and get the output.

  • Refactored to maximize reuse code.
  • Added test to test new functionality (and ensure existing code works as expected).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
random-element added 3 commits October 3, 2018 21:28
@random-element
Ignore venv directory for virtual environments
3b4cca3
@random-element
Split the parsing of input and the exporting of the variables for
f61c0a3 
reuse
@random-element
Added the function so that lambda functions can be called from pytests.
45ffcdc 
The return value of the functions is returned so the test can check the output.
@yxd-hde
yxd-hde requested a review from freedomofkeima October 12, 2018 02:02
yxd-hde
yxd-hde approved these changes Oct 12, 2018
View reviewed changes

@yxd-hde yxd-hde left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
freedomofkeima
freedomofkeima approved these changes Oct 23, 2018
View reviewed changes
@freedomofkeima
freedomofkeima merged commit c6aae27 into HDE:master Oct 23, 2018
@freedomofkeima

freedomofkeima commented Nov 8, 2018

Copy link
Copy Markdown
Collaborator

Related PR: #41
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freedomofkeima freedomofkeima freedomofkeima approved these changes
+1 more reviewer
@yxd-hde yxd-hde yxd-hde approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@random-element @freedomofkeima @yxd-hde
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.