GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Primitive graph realisation by ilya-volkov-ip51 · Pull Request #1 · HowProgrammingWorks/Graph

Conversation

@ilya-volkov-ip51

@ilya-volkov-ip51 ilya-volkov-ip51 commented Mar 11, 2017

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ilya-volkov-ip51 added 4 commits March 10, 2017 18:13
@ilya-volkov-ip51
Creating empty repository
7ca5562
@ilya-volkov-ip51
graph realisation added
c8b4177
@ilya-volkov-ip51
Linter loves my program
1530f4b
@ilya-volkov-ip51
dynamic graph added
421d909
tshemsedinov
tshemsedinov requested changes Mar 12, 2017
View reviewed changes

@tshemsedinov tshemsedinov left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "realisation" ? Do you mean "implementation"?
  2. Do you use eslint before commit?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .jshintrc
{
"esversion": 6,
"node": true
} No newline at end of file

@tshemsedinov tshemsedinov Mar 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at the end of file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread JavaScript/1-DirectedGraph.js
console.dir(graph.incidence());
console.dir(graph.adjacency());
} catch (E) {
console.dir(E.message);

@tshemsedinov tshemsedinov Mar 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use try/except here? Throw error will print message to console, why do you use console.dir instead?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread JavaScript/1-DirectedGraph.js
@@ -0,0 +1,90 @@
/*
Graph in constructor is represented like an array:
[[n, m],

@tshemsedinov tshemsedinov Mar 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not good idea to put n and m as first pair to array

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tshemsedinov tshemsedinov tshemsedinov requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ilya-volkov-ip51 @tshemsedinov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.