GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Draw polygon by pinventado · Pull Request #10 · ILXL/cpputils

Conversation

@pinventado

@pinventado pinventado commented Feb 10, 2021

Copy link
Copy Markdown
Member

I hope I do the library justice :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pinventado added 2 commits February 10, 2021 08:53
@pinventado
Initial DrawPolygon implementation
7ca2918
@pinventado
Fixed point drawing bugs and created unittest
fa984c6
@pinventado
pinventado requested a review from dektar February 10, 2021 17:23
dektar
dektar requested changes Feb 10, 2021
View reviewed changes

@dektar dektar left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be nice to have this functionality! Some comments below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread graphics/image.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread graphics/image.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread graphics/image.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread graphics/image.h
* |color|. Each vertex is represented by it's x and y coordinate, and are
* listed sequentially in the vector. For example, a polygon with three
* vertices (0, 0), (0, 2), (2,1) is represented as a vector of integers
* {0, 0, 0, 2, 2, 1}. The last vertex will connect with the first vertex in

@dektar dektar Feb 10, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little hard to read this polygon vector, especially for large numbers of vertices. What do you think of making a simple graphics::Point class and having a std::vectorgraphics::Point instead?

You could also add a DrawTriangle that takes int x1, int y1, int x2, int y2, int x3, int y3 as that's probably the most common polygon that would be used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread graphics/test/image_unittest.cc
}
}
std::vector<int> points = {20, 20, 20, 22, 22, 21};
image.DrawPolygon(points, red);

@dektar dektar Feb 10, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some polygon-speicifc tests: first, that drawing a polygon clockwise is the same as drawing the same thing counterclockwise? second, if drawing a rect is the same as drawing a polygon with four points?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pinventado added 2 commits February 10, 2021 16:57
@pinventado
Use const references
d382e64
@pinventado
Use const references and fix typos
4021860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dektar dektar dektar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pinventado @dektar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.