GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add PNG error message by flying-sheep · Pull Request #409 · IRkernel/IRkernel

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Sep 21, 2016

Copy link
Copy Markdown
Member

to counter the misconfigured R system issues that crop up.

my stance here is to be as helpful as possible, but not work around a definitely wrong setup.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@flying-sheep
added PNG error message
c18bcec
takluyver
takluyver reviewed Sep 21, 2016
View reviewed changes
Comment thread R/compat.r
if (insane_xlib || insane_cairo) {
help_msg <-
if (!xlib && !cairo) 'install an R that is configured to have either Xlib or cairo support'
else sprintf("put `options(bitmapType='%s')` into your ~/.Rprofile", if (xlib) 'Xlib' else 'cairo')

@takluyver takluyver Sep 21, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know one of them works, can we just switch to that instead of complaining to the user? If it's running on a remote server (e.g. in Jupyterhub), they may well never see this error message, just the kernel dying.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@flying-sheep flying-sheep Sep 21, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don’t see a potential problem here:

  1. the kernel dies immediately
  2. the sysadmin currently setting up jupyterhub will see this
  3. (s)he will fix the error

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@takluyver takluyver Sep 21, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sysadmin may not notice, and if it takes a few days for them to get round to it, the user will conclude that the R kernel doesn't work and either stop trying or come and complain to us.

This is another instance of our usual debate: do we work around a bug or misconfiguration elsewhere, or complain and try to get other people to fix it? In this case (where we have one device that works), I suspect it's not the users' fault that something is picking the wrong default, so why ask them to do manually what we can perfectly well do in our own code? Computers are supposed to be labour-saving devices. ;-)

If you don't like workarounds, then we can try to work out the underlying cause of the issue and get it fixed. If that sounds hard, that's why workarounds are common! Pushing it onto the users is not a substitute.

If it has neither capability and we can't create a png device at all, there's nothing (AFAIK) we can do, so then crashing with an error message seems appropriate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@flying-sheep flying-sheep Sep 21, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can change the abort to a user-visible, non-suppressible warning without having a invasive change to our code, let’s do it! i also don’t want to make the check more than once, that wouldn’t make sense.

If it has neither capability and we can't create a png device at all, there's nothing (AFAIK) we can do, so then crashing with an error message seems appropriate.

OK, so we’re just talking about the case when xlib || cairo is TRUE. sure, we can display a warning and fix the option then!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@takluyver takluyver mentioned this pull request Sep 21, 2016
Kernel automatically dies, xdg-open issue: jupyter/notebook#1775
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takluyver takluyver takluyver left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@flying-sheep @takluyver
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.