GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Scoped display names by enriquepablo · Pull Request #288 · IdentityPython/pyFF

Conversation

@enriquepablo

@enriquepablo enriquepablo commented Jan 8, 2025 •
edited by c00kiemon5ter
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix problem with non-standard OpenAthens ScopedUIInfo elements. Closes issue #287

Please note that the #286 should be merged before this one.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iskandf reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
enriquepablo added 3 commits November 27, 2024 13:57
@enriquepablo
Do not crash when entity-selection-profile attribute has invalid JSON
f733b10
@enriquepablo
warn when trust info has profiles with same name. Also allow extra me…
b392203
…tadata in trust info in entity attribute.
@enriquepablo
fix problem with non-standard OA ScopedUIInfo, close IdentityPython#287
f939db3
@enriquepablo
enriquepablo force-pushed the scoped-display-names branch from fd893c6 to f939db3 Compare January 13, 2025 11:13
@iskandf

iskandf commented Oct 16, 2026

Copy link
Copy Markdown

We hit this in production with pyFF 2.1.5 (the docker.sunet.se/pyff:2.1.5-stable image), and it also affects /api/search, not only the discojson pipe.

Real-world impact: NHS England publishes one OpenAthens IdP (https://idp.eng.nhs.uk/openathens) for 364 organisations. Its IDPSSODescriptor/Extensions holds 364 oaf:ScopedUIInfo elements, followed by the IdP's own mdui:UIInfo ("NHS in England"). /api/search returned the first scoped name, "University Hospitals of Leicester NHS Trust (UHL)", as the title for every NHS England user. Users searching for their own trust thought it was missing, and a customer reported it to us.

Across the UK federation, OpenAthens, InFed, DFN and eduGAIN feeds we load, 180 IdPs carry ScopedUIInfo, and 126 of them got a sub-organisation's name as their title (e.g. NHS Scotland, NHS Wales, several US hospital systems and Japanese universities).

Our workaround, in case it helps others: an xslt step in the per-feed pipeline that moves mdui:UIInfo before the ScopedUIInfo elements, so the first DisplayName in document order is the IdP's own:

<xsl:template match="md:IDPSSODescriptor/md:Extensions[oa:ScopedUIInfo and mdui:UIInfo]">
  <xsl:copy>
    <xsl:apply-templates select="@*"/>
    <xsl:apply-templates select="mdui:UIInfo"/>
    <xsl:apply-templates select="node()[not(self::mdui:UIInfo)]"/>
  </xsl:copy>
</xsl:template>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@enriquepablo @iskandf
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.