GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Conditionally pass Controllers::FS to AlarmController to support save to file by NeroBurner · Pull Request #67 · InfiniTimeOrg/InfiniSim

Conversation

@NeroBurner

@NeroBurner NeroBurner commented Sep 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Support for InfiniTimeOrg/InfiniTime#1367 which is a rebase/improvement
of InfiniTimeOrg/InfiniTime#1333 by @ght

The PR adds saving and restoring alarm state to the SPI NOR flash. So
the AlarmController needs the FileSystem-controller to work.

To support both the current main branch and the "save-alarm-to-file"
PR pass the Filesystem controller conditionally, only if
Controller::FS is mentioned in the AlarmController.h file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NeroBurner
NeroBurner force-pushed the support_alarm_persist_to_flash branch from cef9648 to f46dcc9 Compare October 12, 2022 20:17
@NeroBurner NeroBurner mentioned this pull request Oct 12, 2022
Alarm persist to flash InfiniTimeOrg/InfiniTime#1367
Merged
@NeroBurner NeroBurner added the needs-InfiniTime-change PR blocked until InfiniTime upstream change is merged label Oct 27, 2022
@NeroBurner
Conditionally pass Controllers::FS to AlarmController to support save…
26395a4 
… to file

Support for InfiniTimeOrg/InfiniTime#1367 which is a rebase/improvement
of InfiniTimeOrg/InfiniTime#1333 by @ght

The PR adds saving and restoring alarm state to the SPI NOR flash. So
the AlarmController needs the FileSystem-controller to work.

To support both the current `main` branch and the "save-alarm-to-file"
PR pass the Filesystem controller conditionally, only if
`Controller::FS` is mentioned in the `AlarmController.h` file
@NeroBurner
NeroBurner force-pushed the support_alarm_persist_to_flash branch from f46dcc9 to 26395a4 Compare September 19, 2024 19:30
@NeroBurner NeroBurner changed the title Pass Controllers::FS to AlarmController to support save to file Conditionally pass Controllers::FS to AlarmController to support save to file Sep 19, 2024
@NeroBurner
NeroBurner merged commit 7ade442 into main Sep 19, 2024
@NeroBurner
NeroBurner deleted the support_alarm_persist_to_flash branch September 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-InfiniTime-change PR blocked until InfiniTime upstream change is merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@NeroBurner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.