GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — shakewake: Slightly improve accuracy by FintasticMan · Pull Request #1726 · InfiniTimeOrg/InfiniTime

Conversation

@FintasticMan

@FintasticMan FintasticMan commented Apr 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The (accumulated) speed was calculated by dividing first and multiplying/adding after, which results in more rounding errors than if you multiply/add first and then divide. The values aren't big enough to overflow.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Apr 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 409252B -16B
data 996B 0B
bss 63356B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan FintasticMan added the maintenance Background work label Apr 5, 2023
@FintasticMan
FintasticMan requested a review from a team April 5, 2023 08:52
@JF002

JF002 commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

@FintasticMan What improvement does this PR bring to the user? Or how should we test it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan

FintasticMan commented Apr 17, 2023

Copy link
Copy Markdown
Member Author

This change doesn't affect the user much, if at all. It's just a small change that makes the maths closer what was intended according to the comment in the code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan
FintasticMan force-pushed the improve_shakewake_accuracy branch from 1e2f58f to 68aa58c Compare May 21, 2023 11:31
@FintasticMan
FintasticMan force-pushed the improve_shakewake_accuracy branch from 68aa58c to 0009e03 Compare June 17, 2023 16:09
This was referenced Jun 17, 2023
Improve Raise to Wake algorithm #826
Merged
Implement Lower to Sleep functionality #827
Merged
@FintasticMan
shakewake: Slightly improve accuracy
00a59e8 
The accumulated speed was calculated by dividing first and multiplying
after, which results in more rounding errors than if you multiply first
and then divide. The values aren't big enough to overflow.
@FintasticMan
FintasticMan force-pushed the improve_shakewake_accuracy branch from 0009e03 to 00a59e8 Compare June 25, 2023 14:21
@FintasticMan

FintasticMan commented Aug 17, 2023

Copy link
Copy Markdown
Member Author

Merged with #826.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan FintasticMan closed this Aug 17, 2023
@FintasticMan FintasticMan added this to the 1.14.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@FintasticMan @JF002
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.