GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove the vibration while charging by minacode · Pull Request #1768 · InfiniTimeOrg/InfiniTime

Conversation

@minacode

@minacode minacode commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

This fixes #724 where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PoorPocketsMcNewHold, Krafting, jmlich, applemayexist, NitroNils, ptman, tituscmd, and dimembermatt reacted with thumbs up emoji
All reactions
  • 👍 8 reactions
minacode
DisplayApp.cpp: Remove the vibration from OnChargingEvent
9a56679 
This fixes a bug where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.
@minacode minacode changed the title DisplayApp.cpp: Remove the vibration from OnChargingEvent Remove the vibration from OnChargingEvent Jun 5, 2023
@minacode minacode changed the title Remove the vibration from OnChargingEvent Remove the vibration while charging Jun 5, 2023
@github-actions

github-actions Bot commented Jun 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 374576B -32B
data 948B 0B
bss 63504B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minacode
Merge branch 'InfiniTimeOrg:main' into loading-vibrations
97a55d2
@Itai-Nelken

Itai-Nelken commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

I like this, I have experienced this problem many times. But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minacode

minacode commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

I like this, I have experienced this problem many times.

Nice :) It seems to be a common issue.

But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?

I think that would belong to another PR. This one is only about removing the bug.
Itai-Nelken reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@88572

88572 commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

That's not a problem I have had on the sealed watch, but the vibration is very loud.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minacode
Merge branch 'main' into loading-vibrations
7cdf0ef
@mark9064

mark9064 commented Oct 30, 2023

Copy link
Copy Markdown
Member

Just FYI there is also #1876
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minacode

minacode commented Oct 31, 2023

Copy link
Copy Markdown
Contributor Author

Which I like even more! 😄 I hope your gets merged. We can close this one if it did.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LinuxinaBit

LinuxinaBit commented Nov 9, 2023

Copy link
Copy Markdown

I do like the tactility though, what about only doing the vibration if there hasn’t been a charging event in the last ~1 minute?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
minacode added 2 commits December 11, 2023 11:47
@minacode
Merge branch 'main' into loading-vibrations
b52cd09
@minacode
Merge branch 'InfiniTimeOrg:main' into loading-vibrations
98501a4
@minacode

minacode commented Jan 14, 2024

Copy link
Copy Markdown
Contributor Author

I will keep this PR as simple as possible and just remove the one line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minacode
Merge branch 'main' into loading-vibrations
428763c
mark9064
mark9064 reviewed Nov 24, 2024
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also makes sense to remove the charging event from displayapp as apps pull charging state directly from the batterycontroller; after this change the message would be unused.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
minacode
remove OnChargingEvent message from DisplayApp
7cb7679
@minacode

minacode commented Nov 24, 2024

Copy link
Copy Markdown
Contributor Author

Totally. I removed it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mark9064
mark9064 approved these changes Nov 24, 2024
View reviewed changes
@mark9064 mark9064 added this to the 1.16.0 milestone Nov 24, 2024
@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Nov 24, 2024
@minacode
Merge branch 'main' into loading-vibrations
95899c2
JF002
JF002 approved these changes May 16, 2025
View reviewed changes
@JF002
JF002 merged commit 4e1ee90 into InfiniTimeOrg:main May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Constant vibration when charging

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@minacode @Itai-Nelken @88572 @mark9064 @LinuxinaBit @JF002
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.