GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Date&Time settings label for "Date & Time" by ajira86 · Pull Request #1782 · InfiniTimeOrg/InfiniTime

Conversation

@ajira86

@ajira86 ajira86 commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Proposal to update Date&Time label for issue #1746

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

minacode and TailyFair reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@ajira86
ajira86 force-pushed the feature/date_and_time_label branch 2 times, most recently from 4623463 to 4876860 Compare June 26, 2023 13:02
@github-actions

github-actions Bot commented Jun 26, 2023

Copy link
Copy Markdown

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@FintasticMan FintasticMan added the UI/UX User interface/User experience label Jul 13, 2023
@tituscmd tituscmd mentioned this pull request Oct 2, 2024
datetime: Set the default year to the year during compile #2133
Merged
@NeroBurner NeroBurner added this to the 1.15.0 milestone Oct 3, 2024
NeroBurner
NeroBurner approved these changes Oct 3, 2024
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal change. Looks good. A rebase and conflicts resolved would be nice

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JF002

JF002 commented Oct 27, 2024

Copy link
Copy Markdown
Collaborator

I'm OK with this change, thanks @ajira86 for your contribution!

I'm not sure why the CI is red for build-firmware, build-simulator and test-clang-tidy for such a small change. But since there's a conflict, I tried editing the PR by rebasing on main (since I'm suppose to have this privilege), but I honestly don't know how to make this right.

@ajira86 could you rebase you change on main so we can merge it?
Or does anyone know how to correctly edit a PR from a contributor?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JF002
JF002 approved these changes Oct 27, 2024
View reviewed changes
@mark9064

mark9064 commented Oct 27, 2024

Copy link
Copy Markdown
Member

If the ajira has "repository maintainers can edit this PR" or whatever the option is turned on, you should be able to (force) push directly to their branch IIRC. To do that you just clone their branch as usual and then push onto it, my preferred workflow is to add it as a new remote

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JF002

JF002 commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

When I checkout the @ajira86 's branch, it's checked out as a detached head, so I'm not sure I can push it after I fix the conflict.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ajira86 @FintasticMan
Update Date&Time settings label for "Date & Time"
ace7758
@FintasticMan
FintasticMan force-pushed the feature/date_and_time_label branch from 4876860 to ace7758 Compare November 4, 2024 20:10
@FintasticMan

FintasticMan commented Nov 4, 2024

Copy link
Copy Markdown
Member

I've pushed it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JF002

JF002 commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

@FintasticMan Thanks! :+1 I'll need to learn this feature from Github!

The action build-firmware failed because of the "/" in the branch name so that's not an issue. I'll merge it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JF002
JF002 merged commit afeded0 into InfiniTimeOrg:main Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@NeroBurner NeroBurner NeroBurner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

UI/UX User interface/User experience

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ajira86 @JF002 @mark9064 @FintasticMan @NeroBurner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.