GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PTS: Add setting to display temperature in Fahrenheit by FintasticMan · Pull Request #1805 · InfiniTimeOrg/InfiniTime

Conversation

@FintasticMan

@FintasticMan FintasticMan commented Jul 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This adds a "weather format" setting, which can be either Metric or Imperial.

Fixes #1783.

@kieranc does this look good to you?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
c00ldude1oo and LinuxinaBit reacted with thumbs up emoji 5iver, ludekin3, Commenter25, matoro, and LinuxinaBit reacted with hooray emoji
All reactions
  • 👍 2 reactions
  • 🎉 5 reactions
@FintasticMan FintasticMan added enhancement Enhancement to an existing app/feature weather Bugs and PRs related to Weather labels Jul 15, 2023
@FintasticMan
FintasticMan requested a review from a team July 15, 2023 01:13
@github-actions

github-actions Bot commented Jul 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 369544B 544B
data 940B 0B
bss 63516B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan
FintasticMan force-pushed the fahrenheit_pts branch 3 times, most recently from 539e126 to f1ef573 Compare November 16, 2023 08:45
@JF002

JF002 commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

@FintasticMan Thanks for this PR! I usually refrain from adding new settings but I think we cannot avoid this one : the world use 2 units to measure the temperature, we need to adapt :-)

Would you like to port those changes to the new Simple Weather Service implementation (#1924) ? We'll probably merge it soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan

FintasticMan commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

Yes, I'll rebase this onto #1924 👍
JF002 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan FintasticMan mentioned this pull request Dec 21, 2023
SimpleWeather service : new weather implementation #1924
Merged
@FintasticMan
FintasticMan force-pushed the fahrenheit_pts branch 2 times, most recently from 3f552ce to 6d3c77a Compare December 23, 2023 18:32
JF002
JF002 reviewed Dec 23, 2023
View reviewed changes
Comment thread src/components/ble/SimpleWeatherService.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@FintasticMan
FintasticMan force-pushed the fahrenheit_pts branch 3 times, most recently from 2711ce3 to 1b45e1f Compare December 23, 2023 18:48
JF002
JF002 reviewed Dec 23, 2023
View reviewed changes

@JF002 JF002 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we'll merge this one after #1924 :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FintasticMan FintasticMan mentioned this pull request Dec 23, 2023
weather: Add functions for temperature in Fahrenheit #1785
Closed
FintasticMan added 3 commits December 23, 2023 21:31
@FintasticMan
weather: Add function for temperature in Fahrenheit
562f6f5
@FintasticMan
settings: Add settings item for weather format
ccc62a2
@FintasticMan
pinetimestyle: Display temp in Fahrenheit with setting
89f0f13
@FintasticMan
FintasticMan force-pushed the fahrenheit_pts branch from 1b45e1f to 89f0f13 Compare December 23, 2023 20:32
@JF002 JF002 added this to the 1.14.0 milestone Dec 23, 2023
@JF002
JF002 merged commit e88d0af into InfiniTimeOrg:main Dec 23, 2023
@FintasticMan
FintasticMan deleted the fahrenheit_pts branch December 23, 2023 20:43
@JF002 JF002 mentioned this pull request Dec 24, 2023
Add support for Celsius to Fahreneit conversion InfiniTimeOrg/InfiniSim#136
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature weather Bugs and PRs related to Weather

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Weather: temp won't display in Fahrenheit

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@FintasticMan @JF002
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.