GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Missing character for navigation font by kieranc · Pull Request #2005 · InfiniTimeOrg/InfiniTime

Conversation

@kieranc

@kieranc kieranc commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

Whichever idiot touched the navigation app UI last managed to think about imperial and metric distance units and the characters necessary to represent them, but not that some distances might need the . (period/full stop) character.

The result is that currently, 3.1km displays as 31km, and is somewhat confusing.
I am the idiot. I forgot the . character. This PR fixes my mistake.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Saarsk reacted with laugh emoji mark9064 reacted with heart emoji
All reactions
  • 😄 1 reaction
  • ❤️ 1 reaction
kieranc added 5 commits November 8, 2023 20:52
@kieranc
Initial commit
c59d6e4
@kieranc
Tidy up
9900ab5
@kieranc
Merge remote-tracking branch 'upstream/main' into nav_ui_tweaks
14257bb
@kieranc
Merge remote-tracking branch 'upstream/main' into nav_ui_tweaks
99593a6
@kieranc
Forgotten dot
7308030
@github-actions

github-actions Bot commented Feb 6, 2024

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373108B 0B
data 940B 0B
bss 63516B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
FintasticMan
FintasticMan approved these changes Feb 6, 2024
View reviewed changes

@FintasticMan FintasticMan left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of extra commits from the last PR, but that doesn't matter if we squash merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
NeroBurner
NeroBurner approved these changes Feb 7, 2024
View reviewed changes
@FintasticMan
FintasticMan merged commit 44be356 into InfiniTimeOrg:main Feb 7, 2024
@FintasticMan FintasticMan added this to the 1.15.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes
@FintasticMan FintasticMan FintasticMan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kieranc @NeroBurner @FintasticMan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.