GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Restrict debugging monitor to debug builds by mark9064 · Pull Request #2105 · InfiniTimeOrg/InfiniTime

Conversation

@mark9064

@mark9064 mark9064 commented Aug 23, 2024

Copy link
Copy Markdown
Member

The debugging monitor serves no purpose if a logger isn't available, so the preprocessor check now verifies exactly that. Since the about screen relies on configUSE_TRACE_FACILITY (and presumably won't compile without), I thought there is no point checking that too

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064
Restrict debugging monitor to debug builds
2684f0f
@github-actions

github-actions Bot commented Aug 23, 2024

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 378852B -48B
data 948B 0B
bss 63488B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JF002
JF002 approved these changes Sep 14, 2024
View reviewed changes
@JF002 JF002 added this to the 1.15.0 milestone Sep 14, 2024
@JF002
JF002 merged commit c8236af into InfiniTimeOrg:main Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mark9064 @JF002
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.