GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — weather: Fix inverted imperial forecast temperatures by vkareh · Pull Request #2184 · InfiniTimeOrg/InfiniTime

Conversation

@vkareh

@vkareh vkareh commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

When converting to imperial units, the min and max temperatures were incorrectly inverted, causing confusion in the display.

Fixes #2183

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vkareh
vkareh force-pushed the fix-imperial-temp-order branch from 15c9c1b to ab18cf2 Compare December 6, 2024 16:10
@vkareh vkareh changed the title weather: Fix inverted imperial forecase temperatures weather: Fix inverted imperial forecast temperatures Dec 6, 2024
@github-actions

github-actions Bot commented Dec 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 372816B 0B
data 948B 0B
bss 22536B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mark9064 mark9064 added bug Something isn't working enhancement Enhancement to an existing app/feature labels Dec 6, 2024
mark9064
mark9064 approved these changes Dec 6, 2024
View reviewed changes
@mark9064 mark9064 added this to the 1.16.0 milestone Dec 6, 2024
@vkareh
weather: Fix inverted imperial forecast temperatures
0cc9c9f 
When converting to imperial units, the min and max temperatures were
incorrectly inverted, causing confusion in the display.

Fixes InfiniTimeOrg#2183
@vkareh
vkareh force-pushed the fix-imperial-temp-order branch from ab18cf2 to 0cc9c9f Compare December 9, 2024 21:53
FintasticMan
FintasticMan approved these changes Dec 9, 2024
View reviewed changes

@FintasticMan FintasticMan left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FintasticMan
FintasticMan merged commit d69cfcf into InfiniTimeOrg:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark9064 mark9064 mark9064 approved these changes
@FintasticMan FintasticMan FintasticMan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working enhancement Enhancement to an existing app/feature

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Weather App - High temp incorrectly on bottom row when on imperial format

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vkareh @mark9064 @FintasticMan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.