GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Use artifact v4 instead of v3 by jmlich · Pull Request #2224 · InfiniTimeOrg/InfiniTime

Conversation

@jmlich

@jmlich jmlich commented Jan 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It seems v3 can be directly replaced by v4.

I have seen just issue with naming infinitisim artifact, which is unrelated with migration to v4. See #2223

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mark9064 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jmlich
Fixes InfiniTimeOrg#2219: use artifact v4 instead of v3
fe1326a
@github-actions

github-actions Bot commented Jan 10, 2025

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 372944B 0B
data 948B 0B
bss 22536B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich jmlich changed the title Fixes #2219: use artifact v4 instead of v3 CI: Use artifact v4 instead of v3 Jan 10, 2025
@mark9064 mark9064 added the maintenance Background work label Jan 10, 2025
mark9064
mark9064 approved these changes Jan 10, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only glanced at the changes but it seems to be about functionality we don't use. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
NeroBurner
NeroBurner approved these changes Jan 18, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wht an unfortunately named artifact 😅

Artifact infinisim-.zip successfully finalized. Artifact ID 2411680215

On topic: Changes look gold. Thanks for fixing!

Completely optional: would you like to open a similar PR for InfiniSim?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jmlich jmlich mentioned this pull request Jan 19, 2025
Update github actions to new version InfiniTimeOrg/InfiniSim#168
Merged
@mark9064
mark9064 merged commit de87a0d into InfiniTimeOrg:main Jan 23, 2025
@mark9064 mark9064 mentioned this pull request Jan 23, 2025
Adds vibration strength settings #2231
Closed
@mark9064 mark9064 added this to the 1.16.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jmlich @NeroBurner @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.