GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix about screen vertical centering. by mzrinsky · Pull Request #2279 · InfiniTimeOrg/InfiniTime

Conversation

@mzrinsky

@mzrinsky mzrinsky commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

There was a newline at the end of the last line on the third screen, which was causing the label to not be centered vertically. Removing it fixes the centering.

Here are some before and after screenshots for clarity.

InfiniSim_2025-03-23_055820
InfiniSim_2025-03-23_055918

Thank You!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd and jmlich reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@mzrinsky
Fix about screen vertical centering.
f13d12b 
There was a newline at the end of the last line on the third screen,
which was causing the label to not be centered vertically.
Removing it fixes the centering.
@github-actions

github-actions Bot commented Mar 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373120B 0B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mark9064 mark9064 added the UI/UX User interface/User experience label Mar 24, 2025
mark9064
mark9064 approved these changes Mar 24, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064 mark9064 added this to the 1.16.0 milestone May 16, 2025
JF002
JF002 approved these changes May 19, 2025
View reviewed changes
@JF002
JF002 merged commit fb70b53 into InfiniTimeOrg:main May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

UI/UX User interface/User experience

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mzrinsky @JF002 @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.