GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes the short ref not being set in Github builds by Ghoelian · Pull Request #2282 · InfiniTimeOrg/InfiniTime

Conversation

@Ghoelian

@Ghoelian Ghoelian commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

Fixes the PROJECT_GIT_COMMIT_HASH not getting set in Github builds.

Previously, the step that should get the short ref using git failed:

fatal: detected dubious ownership in repository at '/__w/InfiniTime/InfiniTime'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/InfiniTime/InfiniTime

The checkout action is supposed to do that already, but for some reason it's not working:

Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /__w/InfiniTime/InfiniTime

It looks like this is an issue more people are facing, but for some reason the issue is closed: actions/checkout#1048

The proposed fix of setting the user wasn't working, so I'm just manually adding the cloned repository as safe.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Ghoelian
fix: fix short ref not getting set in github builds
2b97fb9
@github-actions

github-actions Bot commented Mar 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373120B 0B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 approved these changes May 16, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mark9064 mark9064 added this to the 1.16.0 milestone May 16, 2025
@mark9064 mark9064 added the maintenance Background work label May 16, 2025
JF002
JF002 approved these changes May 21, 2025
View reviewed changes
@JF002
JF002 merged commit e27e51d into InfiniTimeOrg:main May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

fatal: detected dubious ownership in repository at

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Ghoelian @JF002 @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.