GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DisplayApp: use std::ranges function where possible by NeroBurner · Pull Request #2300 · InfiniTimeOrg/InfiniTime

Conversation

@NeroBurner

@NeroBurner NeroBurner commented May 24, 2025

Copy link
Copy Markdown
Contributor

Instead of raw for loops use std::ranges::transform where possible.

And also use std::ranges::find_if instead of std::find_if.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NeroBurner NeroBurner added this to the 1.16.0 milestone May 24, 2025
@NeroBurner NeroBurner self-assigned this May 24, 2025
@NeroBurner NeroBurner added the maintenance Background work label May 24, 2025
@NeroBurner
NeroBurner force-pushed the displayapp_use_std_ranges branch 2 times, most recently from f10a5cb to 358f8b6 Compare May 24, 2025 20:08
@NeroBurner
DisplayApp: use std::ranges function where possible
294474b 
Instead of raw for loops use `std::ranges::transform` where possible.
And also use `std::ranges::find_if` instead of `std::find_if`.
@NeroBurner
NeroBurner force-pushed the displayapp_use_std_ranges branch from 358f8b6 to 294474b Compare May 29, 2025 20:35
@InfiniTimeOrg InfiniTimeOrg deleted a comment from github-actions Bot May 29, 2025
@github-actions

github-actions Bot commented May 29, 2025

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 375684B -160B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@NeroBurner
NeroBurner requested a review from a team May 29, 2025 20:50
mark9064
mark9064 approved these changes May 29, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about these, but they're certainly neater. Nice that they exist!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NeroBurner reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@mark9064
mark9064 merged commit 85a0542 into main May 30, 2025
@NeroBurner
NeroBurner deleted the displayapp_use_std_ranges branch May 31, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@NeroBurner NeroBurner

Labels

maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@NeroBurner @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.