GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — CMake Presets json file by sillydan1 · Pull Request #2308 · InfiniTimeOrg/InfiniTime ConversationThis PR adds a I only added one preset, I also found that the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
456bffb to
be8636c
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement overall :) Thanks for sending it in
I'm not sure about storing the toolchain inside the tree. Maybe environment variables like with the VSCode instructions would be more flexible? What are your thoughts, I do agree that having to configure env vars can be a bit annoying
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
be8636c to
a7d43cf
Compare
Thanks! 😁 Hmm... I see your point that using raw environment variables is very flexible, I just found it a bit annoying to use though - which is why I added the cmake presets file... These changes will technically not prevent users from manually setting the environment variables and calling To me, ideally, the buildsteps should just be:
Where the CMakeLists.txt would download the SDK and toolchain for you at configure-time. I would love to try to get that done but it would require touching the CI and it would be a fairly big change to the now normal work flow, so I'm not sure if it would be too disruptive. Perhaps adding the presets just adds confusion and we should just close this PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
CMakeUserPresets.json contains user (i.e. per developer) presets and should therefore be ignored. node_modules and so on is just for the lv_font_conv dependency.
This file helps editors to generate compile_commands.json database files as well as streamlining some of the cmake commands.
a7d43cf to
f2620b2
Compare
|
Closing as this became stale. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.