GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor documentation tweaks by WhyNotHugo · Pull Request #2335 · InfiniTimeOrg/InfiniTime

Conversation

@WhyNotHugo

@WhyNotHugo WhyNotHugo commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

See commit messages for finer details.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions

github-actions Bot commented Jul 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 380132B 0B
data 944B 0B
bss 22544B 0B

Run in InfiniEmu

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064 mark9064 added the documentation Improvements or additions to documentation label Aug 5, 2025
@WhyNotHugo

WhyNotHugo commented Aug 30, 2025

Copy link
Copy Markdown
Contributor Author

Kind ping

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented Sep 2, 2025

Copy link
Copy Markdown
Member

Sorry for the delay! I'm away for a couple weeks but I'll try look over this when I can :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064
mark9064 self-requested a review September 2, 2025 17:12
mark9064
mark9064 reviewed Sep 15, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads much better now :)

Not a docker expert so I can't review that too closely but all your reasoning looks sound to me (thanks for the great commit messages!)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread doc/buildAndProgram.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

WhyNotHugo added 4 commits September 16, 2025 09:35
@WhyNotHugo
docs: shuffle sections into logical order
3e3a9a2
The first section explains how to clone the repository, the second how
to build Infinitime with the docker image, but the details on actually
provisioning the image are at the end, despite this step taking place
before the build itself.

Move the sections into the order in which the steps should be followed.
@WhyNotHugo
docker: update deprecated syntax
5cc1a5d
`docker build` warns of deprecated syntax:

    1 warning found (use docker --debug to expand):
    - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 71)

Update Dockerfile, removing the deprecated syntax usage.
@WhyNotHugo
docs: remove superfluous link
f0c4049
The docker build section points to another page with instructions on how
to clone the repository, but this same page already contains these same
instructions in the previous section.
@WhyNotHugo
docs: --user is only required when docker run as root
f008b27
The --user argument attempts to map the uid of the user inside the
container to the user in the host. This works if docker is running as
root, but is docker is running as the current user, then the uid in the
container is mapped to a surrogate uid on the host, and this surrogate
user does not have permissions to complete the build process.

Clarify that the --user flag is only required when running docker as
root. It is also likely not required by users using podman as a docker
drop-in replacement, since podman always runs in rootless mode.
@WhyNotHugo
WhyNotHugo force-pushed the docs branch from 0e72cac to f008b27 Compare September 16, 2025 07:36
mark9064
mark9064 approved these changes Sep 16, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks :)

Reviewer note: will merge in a week or so if no other reviews as this is a doc change only

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mark9064 mark9064 added this to the 1.16.0 milestone Sep 16, 2025
@mark9064
mark9064 merged commit 957ba59 into InfiniTimeOrg:main Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark9064 mark9064 mark9064 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@WhyNotHugo @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.