GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — Minor documentation tweaks by WhyNotHugo · Pull Request #2335 · InfiniTimeOrg/InfiniTime Conversation
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Kind ping |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry for the delay! I'm away for a couple weeks but I'll try look over this when I can :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Reads much better now :)
Not a docker expert so I can't review that too closely but all your reasoning looks sound to me (thanks for the great commit messages!)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
The first section explains how to clone the repository, the second how to build Infinitime with the docker image, but the details on actually provisioning the image are at the end, despite this step taking place before the build itself. Move the sections into the order in which the steps should be followed.
`docker build` warns of deprecated syntax:
1 warning found (use docker --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 71)
Update Dockerfile, removing the deprecated syntax usage.
The docker build section points to another page with instructions on how to clone the repository, but this same page already contains these same instructions in the previous section.
The --user argument attempts to map the uid of the user inside the container to the user in the host. This works if docker is running as root, but is docker is running as the current user, then the uid in the container is mapped to a surrogate uid on the host, and this surrogate user does not have permissions to complete the build process. Clarify that the --user flag is only required when running docker as root. It is also likely not required by users using podman as a docker drop-in replacement, since podman always runs in rootless mode.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks :)
Reviewer note: will merge in a week or so if no other reviews as this is a doc change only
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.