GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use std::optional for heart rate by WhyNotHugo · Pull Request #2342 · InfiniTimeOrg/InfiniTime

Conversation

@WhyNotHugo

@WhyNotHugo WhyNotHugo commented Aug 30, 2025

Copy link
Copy Markdown
Contributor

If no value is available, use null. Use this distinction to differentiate in the UI between missing data and zero value.

Still sends value 0 over BLE. I'm unsure whether this should change or not

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WhyNotHugo WhyNotHugo mentioned this pull request Aug 30, 2025
Background HR #2322
Merged
@WhyNotHugo
Use std::optional for heart rate
8df49f4 
If no value is available, use null. Use this distinction to
differentiate in the UI between missing data and zero value.

Still sends value 0 over BLE. I'm unsure whether this should
change or not
@WhyNotHugo
WhyNotHugo force-pushed the null-hr branch from 3d1ee6d to 8df49f4 Compare August 30, 2025 02:34
@github-actions

github-actions Bot commented Aug 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 379348B 144B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WhyNotHugo

WhyNotHugo commented Aug 30, 2025

Copy link
Copy Markdown
Contributor Author

Checks have not completed because they require maintainer approval.

This isn't something I can do anything about, I'm not sure what's the purpose of this warning.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WhyNotHugo

WhyNotHugo commented Aug 30, 2025

Copy link
Copy Markdown
Contributor Author

Building the simulator fails.

docker run --rm -it -v ${PWD}:/sources infinitime-build doesn't build the simulator too. I tried tweaking it to build it, but apparently multiple other dependencies are missing.

Is there an existing setup for this which I can use?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@NeroBurner NeroBurner added the enhancement Enhancement to an existing app/feature label Aug 30, 2025
@WhyNotHugo

WhyNotHugo commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

See: InfiniTimeOrg/InfiniSim#180
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WhyNotHugo WhyNotHugo mentioned this pull request Sep 22, 2025
Use std::optional for heart rate InfiniTimeOrg/InfiniSim#180
Open
@mark9064 mark9064 mentioned this pull request Nov 7, 2025
Watch faces display obviously bogus 0 as heart rate #2362
Open
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@WhyNotHugo @NeroBurner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.