GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove redundant touchpanel read by mark9064 · Pull Request #2349 · InfiniTimeOrg/InfiniTime

Conversation

@mark9064

@mark9064 mark9064 commented Oct 7, 2025

Copy link
Copy Markdown
Member

Split from #2325

According to the datasheet there is nothing at register 0. So I figured we probably shouldn't be trying to read it. It's a machine translation though so maybe something is missing? https://wiki.pine64.org/images/2/2f/CST816S.zip

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064
Remove redundant touchpanel read
ccc6143
@mark9064 mark9064 added this to the 1.16.0 milestone Oct 7, 2025
@mark9064
mark9064 requested a review from NeroBurner October 7, 2025 23:30
@mark9064 mark9064 added the maintenance Background work label Oct 7, 2025
@mark9064 mark9064 mentioned this pull request Oct 7, 2025
Touchscreen timeout fix #2325
Merged
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 380132B 0B
data 944B 0B
bss 22544B 0B

Run in InfiniEmu
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NeroBurner
NeroBurner approved these changes Oct 8, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064
mark9064 merged commit 0881edd into InfiniTimeOrg:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mark9064 @NeroBurner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.