GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up scripts for old website by tsadler1988 · Pull Request #391 · InnerSourceCommons/InnerSourceLearningPath

Conversation

@tsadler1988

@tsadler1988 tsadler1988 commented Mar 31, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Note this has been branched from #390, so also contains those changes. #390 merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tsadler1988
Clean up scripts for old website
01cb654
@tsadler1988
tsadler1988 requested a review from a team as a code owner March 31, 2021 19:59
@tsadler1988 tsadler1988 changed the title New site live scripts cleanup Clean up scripts for old website Mar 31, 2021
@lenucksi lenucksi added the Website label Apr 1, 2021
@lenucksi

lenucksi commented Apr 1, 2021

Copy link
Copy Markdown
Member

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tsadler1988

tsadler1988 commented Apr 1, 2021

Copy link
Copy Markdown
Collaborator Author

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

I'm not sure about this - do you mean links referenced in the videos? If so, that would probably need a redirect/permalink set up in the new Hugo site. Happy to take a look, but would prefer raising as a separate issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tsadler1988
Merge remote-tracking branch 'origin/master' into new-site-live-scrip…
7203898
…ts-cleanup
@rrrutledge

rrrutledge commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

Why does it appear that we are making functional code changes, here? Is it just refactoring?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lenucksi lenucksi mentioned this pull request Apr 2, 2021
Track possible links in our videos that we'd need to keep active. Equip new Hugo website with redirects accordingly. #393
Open
@lenucksi

lenucksi commented Apr 2, 2021

Copy link
Copy Markdown
Member

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

I'm not sure about this - do you mean links referenced in the videos? If so, that would probably need a redirect/permalink set up in the new Hugo site. Happy to take a look, but would prefer raising as a separate issue.

Created #393 for this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tsadler1988

tsadler1988 commented Apr 6, 2021

Copy link
Copy Markdown
Collaborator Author

Why does it appear that we are making functional code changes, here? Is it just refactoring?

Should just be a refactor, but it is quite a big one. I've pulled logic out of generate_hugo_learning_path_markdown.js and put it into generate_learning_path_markdown.js, which might be why it looks like functional change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rrrutledge

rrrutledge commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

I'd like to review by actually trying this out but not sure exactly when I'll have time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tsadler1988

tsadler1988 commented Apr 6, 2021

Copy link
Copy Markdown
Collaborator Author

No worries @rrrutledge, I don't think this is blocking anything right now so no rush.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rrrutledge
rrrutledge approved these changes Apr 29, 2021
View reviewed changes

@rrrutledge rrrutledge left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I used it for InnerSourceCommons/innersourcecommons.org#115

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rrrutledge
rrrutledge merged commit e1be0ac into master Apr 29, 2021
@rrrutledge
rrrutledge deleted the new-site-live-scripts-cleanup branch April 29, 2021 16:57
@lenucksi

lenucksi commented May 1, 2021

Copy link
Copy Markdown
Member

Sounds like this could be ready to be used in GitHub actions for automation purposes?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rrrutledge

rrrutledge commented May 3, 2021

Copy link
Copy Markdown
Contributor

Sounds like this could be ready to be used in GitHub actions for automation purposes?

I think so - just need to wire it up.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrrutledge rrrutledge rrrutledge approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tsadler1988 @lenucksi @rrrutledge
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.