GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clarify Contributor workbook question by rrrutledge · Pull Request #446 · InnerSourceCommons/InnerSourceLearningPath

Conversation

@rrrutledge

@rrrutledge rrrutledge commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

Fixes #122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rrrutledge
Clarify Contributor workbook question
d06b63f 
Fixes #122
@rrrutledge
rrrutledge requested review from Ludmila-N, MaineC and lenucksi August 20, 2021 13:45
@rrrutledge
rrrutledge requested a review from a team as a code owner August 20, 2021 13:45
@lenucksi lenucksi added the Workbook Related to the Workbook label Aug 30, 2021
lenucksi
lenucksi approved these changes Aug 30, 2021
View reviewed changes

@lenucksi lenucksi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like those clarifications and they LGTM but would like to hint to another addition @Ludmila-N made in #122 (comment):
"Question 1, answer 4 has the explanation that was never mentioned in the video, suggest rewriting this option:" (Contributor section, Contributor Ethos)

Maybe we can get another commit on those before we merge it? Maybe we can rephrase it along the lines of "a proven pattern for this problem ist ... 30-days-of-warranty" or so?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rrrutledge reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@rrrutledge

rrrutledge commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

Question 1, answer 4 has the explanation that was never mentioned in the video

Although not in the video, it is in the article, which we've said before is fair game.
lenucksi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rrrutledge
rrrutledge merged commit 18218b9 into master Sep 6, 2021
@rrrutledge
rrrutledge deleted the workbook/contributor branch September 6, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenucksi lenucksi lenucksi approved these changes
@MaineC MaineC Awaiting requested review from MaineC
@Ludmila-N Ludmila-N Awaiting requested review from Ludmila-N

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Workbook Related to the Workbook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check videos against workbook after creation

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rrrutledge @lenucksi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.