GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added concurrency section to Publish Website workflow (Issue 575) by marshmallowrobot · Pull Request #583 · InnerSourceCommons/InnerSourceLearningPath

Conversation

@marshmallowrobot

@marshmallowrobot marshmallowrobot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

When builds are triggered within about 4 min of each other, the parallel calls to GitHub's GraphQL API clobber one another. Even with a throttling helper, the clobbering results in a too-many-requests API error, and the build fails.

This small change should hopefully prevent this error in the future. It will check if the build/workflow is already running, and if so, cancels it. If there are multiple builds in quick succession, only the latest one will publish.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marshmallowrobot
Added concurrency section to Publish Website workflow
9b5d31d
@marshmallowrobot
marshmallowrobot requested a review from a team as a code owner August 15, 2023 14:01
@marshmallowrobot marshmallowrobot changed the title Added concurrency section to Publish Website workflow Added concurrency section to Publish Website workflow (Issue 575) Aug 15, 2023
@marshmallowrobot marshmallowrobot mentioned this pull request Aug 15, 2023
Website build is failing #575
Open
@marshmallowrobot marshmallowrobot linked an issue Aug 15, 2023 that may be closed by this pull request
Website build is failing #575
Open
tsadler1988
tsadler1988 approved these changes Aug 15, 2023
View reviewed changes

@tsadler1988 tsadler1988 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tsadler1988

tsadler1988 commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Docs for reference: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow
marshmallowrobot reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marshmallowrobot
marshmallowrobot merged commit 2d6d8bc into main Aug 15, 2023
@marshmallowrobot
marshmallowrobot deleted the 575-concurrent-builds branch August 15, 2023 14:52
@rrrutledge

rrrutledge commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Great work!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsadler1988 tsadler1988 tsadler1988 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Website build is failing

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@marshmallowrobot @tsadler1988 @rrrutledge
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.