GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Create include-product-owners.md by NewMexicoKid · Pull Request #71 · InnerSourceCommons/InnerSourcePatterns

Conversation

@NewMexicoKid

@NewMexicoKid NewMexicoKid commented May 3, 2017

Copy link
Copy Markdown
Collaborator

This was created at the Spring Summit 2017 in Geneva, Switzerland.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@NewMexicoKid
Create include-product-owners.md
0ef8195
This was created at the Spring Summit 2017 in Geneva, Switzerland.
@NewMexicoKid NewMexicoKid added 1 - Do 1st Review 3-validated Patterns proven in multiple cases with advanced requirements (Please see our contribution handbook) labels May 3, 2017
ErinMB added 2 commits May 9, 2017 15:10
@ErinMB
Update include-product-owners.md
b08a8d2
Started revising & cleanup - not finished yet - will come back
@ErinMB
Update include-product-owners.md
da48704
Cleaned up / revised each line item.
@ErinMB ErinMB removed the 3-validated Patterns proven in multiple cases with advanced requirements (Please see our contribution handbook) label May 11, 2017
@NewMexicoKid
Added Alex Bozic as co-author
e7cf95f
@maxcapraro maxcapraro added the Stale We mark issues as stale after 90 days of inactivity. This does not make any judgement about value. label Apr 21, 2020
@spier

spier commented Apr 26, 2020

Copy link
Copy Markdown
Member

@NewMexicoKid about this pattern:
Do you know if this pattern is already proven (state)?
Also would you mind adding a Patlet to it?

Maybe the most important question:
Are you able to work on this pattern, or should I reach out to somebody else, or as the last resort should we close this PR and keep the pattern only as a draft?

lenucksi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@spier

spier commented Aug 11, 2020

Copy link
Copy Markdown
Member

Hi @NewMexicoKid (mentioning you as you spent quite some time on this PR already).

We have reworked the maturity levels of the InnerSource patterns. The new levels make it more explicit what quality standards are expected for each level. With that we will also try to get PRs merged into master faster.

Status of this pattern:

We have currently categorized the Pattern in this PR as maturity level Level 2 - Structured.

For that level we have two requirements:

  • is validated by at least one known instance
    • we suspect that this is already true, as this pattern was previously listed in the group Pattern Drafts (proven, not yet fully reviewed)
  • complies with the patterns format
    • not sure about this, especially as the pattern format may have evolved since this PR was opened

How to get this PR merged?

  • Could you confirm if the status assessment above sounds correct to you?
  • If this pattern does not match the patterns format yet, could you adapt it accordingly?
  • With that we should be able to merge this PR to master. That will also allow other contributors to level up this pattern further in subsequent PRs/contributions in the future.

I have no time to work on this, what to do?

As this PR is open for a while, it would be completely understandable if your priorities have shifted and you don't time to work on this anymore.

In that case please just let us know in a comment below. Then we can decide what to do with this PR on our own.

Thank you for your help! 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lenucksi lenucksi removed the 1 - Do 1st Review label Sep 21, 2020
@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Dec 26, 2020
@spier spier mentioned this pull request Dec 27, 2020
Solidify patterns in Maturity Level 2: Structured #259
Closed
spier added 8 commits January 22, 2021 06:02
@spier
Merge remote-tracking branch 'origin/master' into pattern/include-pro…
9aacaf4
…duct-owners
@spier
adapting to format requirements for the Pattern Template
465a38e
@spier
fixing some typos and spelling of InnerSource
c3820bd
@spier
add suggested status for this pattern
77e6458
@spier
explain status better. one fix to a section title
73051fa
@spier
further fixes to InnerSource spelling
83a7392
@spier
move pattern to the level-1 group in the readme. sync summar in READM…
e1d9ba6
…E and Pattern
@spier
move pattern to 'patterns/1-initial'. add link to file, rather than t…
0fdf59d
…o the PR
@NewMexicoKid
NewMexicoKid requested review from cewilliams, gruetter, lenucksi, nyeates and spier as code owners January 22, 2021 05:16
@spier

spier commented Jan 22, 2021

Copy link
Copy Markdown
Member

@NewMexicoKid I made a number of changes to align this pattern with the Pattern Template and to move it into our new maturity levels.

I decided to move it to Level 1 (Initial) for now.

Things missing to move it to Level 2:

  • Patlet
  • Expanded explanation of the Known Instance. Based on the current description I am not sure if that Known Instance was actually implemented or rather an idea? (See "PayPal is looking into finding a search solution" link)
  • Cross-referencing and linking it to other patterns that may have been created in the meantime.

Given that this pattern has been sitting here as a PR for a long time, my suggestion would be to merge this pattern as Level 1 (Initial). Then we can wait and see if gets confirmed and improved by others in the community.

What do you think?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@spier spier removed the Stale We mark issues as stale after 90 days of inactivity. This does not make any judgement about value. label Jan 22, 2021
NewMexicoKid
NewMexicoKid commented Jan 22, 2021
View reviewed changes
Comment thread patterns/1-initial/include-product-owners.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

NewMexicoKid
NewMexicoKid commented Jan 22, 2021
View reviewed changes

@NewMexicoKid NewMexicoKid left a comment

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay (I added a suggestion for a patlet).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
spier
spier reviewed Jan 22, 2021
View reviewed changes
Comment thread patterns/1-initial/include-product-owners.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@spier
Update patterns/1-initial/include-product-owners.md
2208f6a
spier
spier reviewed Jan 22, 2021
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@spier
Update README.md
4bdb64d
@spier
spier merged commit 9ea67cb into master Jan 22, 2021
@spier
spier deleted the pattern/include-product-owners branch January 22, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spier spier spier left review comments
@cewilliams cewilliams Awaiting requested review from cewilliams
@gruetter gruetter Awaiting requested review from gruetter
@lenucksi lenucksi Awaiting requested review from lenucksi
@nyeates nyeates Awaiting requested review from nyeates

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

📖 Type - Content Work Working on contents is the main focus of this issue / PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@NewMexicoKid @spier @lenucksi @maxcapraro @ErinMB
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.