GeezerVison is showing github.com — ENH: Update Windows download and build script by tbirdso · Pull Request #242 · InsightSoftwareConsortium/ITKPythonPackage
Conversation
tbirdso
commented
Dec 13, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Windows PowerShell "download and build" script was previously unmaintained and unused in reusable workflows and in ITKModuleTemplate. These changes along with upcoming revisions to
ITKRemoteModuleBuildTestPackageAction will consolidate Windows build procedures in ITKPythonPackage for consistency with Linux and MacOS build processes.
Standardizing Windows build procedures will improve maintainability and also support upcoming changes to handle iterative ITK module build dependencies in build scripts.
Windows Python builds are passing with these changes: https://github.com/tbirdso/ITKSplitComponents/actions/runs/3685964482/jobs/6237566090
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Windows PowerShell "download and build" script was previously
unmaintained and unused in reusable workflows and in ITKModuleTemplate.
These changes along with upcoming revisions to
ITKRemoteModuleBuildTestPackageAction will consolidate Windows build
procedures in ITKPythonPackage for consistency with Linux and MacOS
build processes.
Standardizing Windows build procedures will improve maintainability and
also support upcoming changes to handle ITK module build dependencies
in build scripts.
Reviewers
dzenanz
dzenanz approved these changes
thewtex
Awaiting requested review from thewtex
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.