GeezerVison is showing github.com — Fix: mysql comment with `=` (#1936) · JSQLParser/JSqlParser@0244905
File treeExpand file treeCollapse file tree Open diff view settings java/net/sf/jsqlparser/statement/alter jjtree/net/sf/jsqlparser/parser
test/java/net/sf/jsqlparser/statement/alter
Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: src/main/java/net/sf/jsqlparser/statement/alter/AlterExpression.java +5-2Lines changed: 5 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -442,8 +442,11 @@ public String toString() { | 442 | 442 | // Oracle Multi Column Drop | 443 | 443 | b.append("DROP (").append(PlainSelect.getStringList(pkColumns)).append(')'); | 444 | 444 | } else { | 445 | | - b.append(operation).append(" "); | 446 | | - | | 445 | + if (operation == AlterOperation.COMMENT_WITH_EQUAL_SIGN) { | | 446 | + b.append("COMMENT =").append(" "); | | 447 | + } else { | | 448 | + b.append(operation).append(" "); | | 449 | + } | 447 | 450 | if (commentText != null) { | 448 | 451 | if (columnName != null) { | 449 | 452 | b.append(columnName).append(" COMMENT "); | |
Collapse file Copy file name to clipboardExpand all lines: src/main/java/net/sf/jsqlparser/statement/alter/AlterOperation.java +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
| 10 | 10 | package net.sf.jsqlparser.statement.alter; | 11 | 11 |
| 12 | 12 | public enum AlterOperation { | 13 | | - ADD, ALTER, DROP, DROP_PRIMARY_KEY, DROP_UNIQUE, DROP_FOREIGN_KEY, MODIFY, CHANGE, ALGORITHM, RENAME, RENAME_TABLE, RENAME_INDEX, RENAME_KEY, RENAME_CONSTRAINT, COMMENT, UNSPECIFIC; | | 13 | + ADD, ALTER, DROP, DROP_PRIMARY_KEY, DROP_UNIQUE, DROP_FOREIGN_KEY, MODIFY, CHANGE, ALGORITHM, RENAME, RENAME_TABLE, RENAME_INDEX, RENAME_KEY, RENAME_CONSTRAINT, COMMENT, COMMENT_WITH_EQUAL_SIGN, UNSPECIFIC; | 14 | 14 |
| 15 | 15 | public static AlterOperation from(String operation) { | 16 | 16 | return Enum.valueOf(AlterOperation.class, operation.toUpperCase()); | |
Collapse file Copy file name to clipboardExpand all lines: src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt +1Lines changed: 1 addition & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -6500,6 +6500,7 @@ AlterExpression AlterExpression(): | 6500 | 6500 | ) | 6501 | 6501 | | | 6502 | 6502 | (<K_COMMENT> {alterExp.setOperation(AlterOperation.COMMENT);} | | 6503 | + ["=" {alterExp.setOperation(AlterOperation.COMMENT_WITH_EQUAL_SIGN);} ] | 6503 | 6504 | tk=<S_CHAR_LITERAL> { alterExp.setCommentText(tk.image); } | 6504 | 6505 | ) | 6505 | 6506 | | | |
Collapse file Copy file name to clipboardExpand all lines: src/test/java/net/sf/jsqlparser/statement/alter/AlterTest.java +6Lines changed: 6 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -896,6 +896,12 @@ public void testAlterTableDropColumnIfExists() throws JSQLParserException { | 896 | 896 | assertSqlCanBeParsedAndDeparsed("ALTER TABLE test DROP COLUMN IF EXISTS name"); | 897 | 897 | } | 898 | 898 |
| | 899 | + @Test | | 900 | + public void testAlterTableCommentIssue1935() throws JSQLParserException { | | 901 | + assertSqlCanBeParsedAndDeparsed("ALTER TABLE table_name COMMENT = 'New table comment'"); | | 902 | + assertSqlCanBeParsedAndDeparsed("ALTER TABLE table_name COMMENT 'New table comment'"); | | 903 | + } | | 904 | + | 899 | 905 | @Test | 900 | 906 | public void testAlterTableDropMultipleColumnsIfExists() throws JSQLParserException { | 901 | 907 | assertSqlCanBeParsedAndDeparsed( | |
|