Description

leotu

opened on Sep 15, 2022

Issue body actions

• https://www.postgresql.org/docs/current/sql-insert.html

"...UPDATE SET column"

Code: InsertConflictAction.java

There is no public method to get variable "updateSets".

public class InsertConflictAction {
    ConflictActionType conflictActionType;

    private final ArrayList<UpdateSet> updateSets = new ArrayList<>();
    Expression whereExpression;
...
}

InsertConflictAction conflictAction = insert.getConflictAction();
Missing method ==> conflictAction.getUpdateSets() ?

Activity

1. manticore-projects commented on Sep 15, 2022

   

   manticore-projects

   on Sep 15, 2022

   Contributor

   More actions

   Greetings.

   There is no public method to get variable "updateSets".

   There certainly is in JSQLParser 4.6 SNAPSHOT:
   

   What version of JSQLParser are you using please.
   You can try it online here
2. leotu commented on Sep 15, 2022

   

   leotu

   on Sep 15, 2022

   Author

   More actions

   jsqlparser version 4.5
3. manticore-projects commented on Sep 15, 2022

   

   manticore-projects

   on Sep 15, 2022

   Contributor

   More actions

   Apologies, I have checked the code and indeed a public Getter is missing.
   I would add it asap and issue a PR.

   Thank you for notifying!
4. manticore-projects

   self-assigned this

   on Sep 15, 2022
5. manticore-projects

   added a commit that references this issue on Sep 15, 2022

   fix: add missing public Getter

   This issue will close once commit 09c2fb7 is merged into the 'master' branch.

   09c2fb7
6. manticore-projects commented on Sep 15, 2022

   

   manticore-projects

   on Sep 15, 2022

   Contributor

   More actions

   I have issued PR #1632
   You can use the attached Snapshot JAR as a remedy.
   jsqlparser-4.5-SNAPSHOT.zip

   Thank you again for your report!

   Reacted by Leo
7. wumpz

   closed this as completedin #1632on Sep 20, 2022
8. wumpz

   added a commit that references this issue on Sep 20, 2022

   fix: add missing public Getter (#1632)

   This issue will close once commit d221277 is merged into the 'master' branch.

   d221277
9. wumpz

   added a commit that references this issue on Oct 16, 2022

   Assorted fixes (#1646)

   This issue will close once commit 15ff843 is merged into the 'master' branch.

   15ff843
10. wumpz

    added a commit that references this issue on Nov 20, 2022

    Assorted fixes (#1666)

    This issue will close once commit bff268a is merged into the 'master' branch.

    bff268a
11. wumpz

    added a commit that references this issue on Dec 22, 2022

    Assorted Fixes #4 (#1676)

    This issue will close once commit 8d9db70 is merged into the 'master' branch.

    8d9db70
12. wumpz

    added a commit that references this issue on Jan 31, 2023

    Issue1673 case within brackets (#1675)

    This issue will close once commit 2ced7de is merged into the 'master' branch.

    2ced7de

Issue actions