Description

csakhogy

opened on Apr 27, 2023

Issue body actions

Failing SQL Feature:

• Join.isInner() method does not return TRUE as expected when the optional keyword 'INNER' is ommitted from SQL-standard syntax "(INNER) JOIN".

SQL Example:

• tbd

Software Information:

• JSqlParser version: 4.60
• Database: any

Tips:

none.

Activity

1. manticore-projects commented on Apr 27, 2023

   

   manticore-projects

   on Apr 27, 2023

   Contributor

   More actions

   Yes, because Join.isInner() solely indicates if the INNER keyword is present but does not give any information about the execution plan. See, we need to De-Parse the JOIN expression and need to know if to print (or not) the INNER keyword.
2. manticore-projects

   closed this as completedon Apr 27, 2023
3. csakhogy commented on Apr 29, 2023

   

   csakhogy

   on Apr 29, 2023

   Author

   More actions

   Would not be useful having "by default" a method that tells they type of Join component of SQL script? Or is there such I have not found yet? Though I easily overcome this by a helper method calling all availabe .IsInner(), .isLeft(), etc, binary "questions"...
4. manticore-projects

   added a commit that references this issue on Apr 30, 2023

   feat: Test if a JOIN is an INNER JOIN according to the SQL:2016

   This issue will close once commit 6281b07 is merged into the 'master' branch.

   6281b07
5. manticore-projects

   added a commit that references this issue on Jun 1, 2023

   JSQLParser 5.0 (#1778)

   This issue will close once commit 41b6fce is merged into the 'master' branch.

   41b6fce
6. manticore-projects

   added a commit that references this issue on Jun 15, 2023

   Assorted Fixes #8 (#1807)

   This issue will close once commit a815f5f is merged into the 'master' branch.

   a815f5f
7. manticore-projects

   added a commit that references this issue on Jun 27, 2023

   Backslash Quotation of Single-Quote `'\\''` (#1813)

   This issue will close once commit c79dfff is merged into the 'master' branch.

   c79dfff

Issue actions