Description

daredevil2033

opened on May 4, 2023

Issue body actions

• Mode switch has three buttons (half-full circle, sun, crescent) but only two change the mode (crescent doesn't)
• sphinx-tabs-tab color doesn't account for dark mode (used in Compile from Source Code and Build Dependencies)
• Syntax Railroad diagrams don't account for dark mode
• Some of the Syntax Railroad diagrams are obstructed (such as JsonFunction, JsonAggregateFunction, CreateTable and AlterExpression)
• Some of the Syntax EBNF diagrams are obstructed (such as Ll and Lu)

Activity

1. manticore-projects commented on May 4, 2023

   

   manticore-projects

   on May 4, 2023

   Contributor

   More actions

   Thanks for reporting.

   • Mode switch has three buttons (half-full circle, sun, crescent) but only two change the mode (crescent doesn't)

   As far as I understand it, Tri-State makes sense: Sun - enforce bright, Moon - enforce dark, Crescent - follow the system settings.

   • sphinx-tabs-tab color doesn't account for dark mode (used in Compile from Source Code and Build Dependencies)

   Fixed by a590036

   • Syntax Railroad diagrams don't account for dark mode

   Mitigated via Commit c81d60a
   Although a better Dark Mode Support for the SVG stylesheet would be great. Any volunteers?

   • Some of the Syntax Railroad diagrams are obstructed (such as JsonFunction, JsonAggregateFunction, CreateTable and AlterExpression)

   Yes, but the only solution was to refactor the Productions in the Grammar.
   Especially the ALTER TABLE... and CREATE TABLE... need some serious work.

   • Some of the Syntax EBNF diagrams are obstructed (such as Ll and Lu)

   I will look into this one. Also the Spelling is broken and needs to be fixed.
2. manticore-projects

   added 2 commits that reference this issue on May 6, 2023

   doc: Better Sphinx Tabs

   a590036

   doc: RR chart colors cater for Dark Mode

   c81d60a
3. manticore-projects

   added a commit that references this issue on Jun 1, 2023

   JSQLParser 5.0 (#1778)

   41b6fce
4. manticore-projects

   closed this as completedin #1807on Jun 15, 2023
5. manticore-projects

   added a commit that references this issue on Jun 15, 2023

   Assorted Fixes #8 (#1807)

   a815f5f
6. manticore-projects

   added a commit that references this issue on Jun 27, 2023

   Backslash Quotation of Single-Quote `'\\''` (#1813)

   c79dfff

Issue actions