GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — compound statement tests by rathboma · Pull Request #1545 · JSQLParser/JSqlParser

Conversation

@rathboma

@rathboma rathboma commented May 28, 2022

Copy link
Copy Markdown
Contributor

Hey!

I didn't see any tests for anonymous statement blocks so figured I'd add them!

So I added three new tests for compound statements / anonymous blocks

  • https://docs.oracle.com/cd/E17952_01/mysql-5.7-en/begin-end.html
  • https://blogs.oracle.com/connect/post/building-with-blocks

Note in the SQL files it says that the tests failed...but mvn test doesn't seem to show that at all? Not sure what I'm doing wrong, but wanted to make a PR anyway to see if the failures are legit?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rathboma
compound statement tests
e34d5ac
@manticore-projects

manticore-projects commented May 28, 2022

Copy link
Copy Markdown
Contributor

Greetings!

First of all, thanks a lot for interest and contributing. Well appreciated.

On the details, we may need a few changes:

  1. You have touched that "Special Oracle Tests" section, which is not advisable. This section is reserved for exotic Oracle features, and some of them are meant/known to fail -- and thus its silent.

  2. Instead move your Tests into the normal test section and use the standard assertCanBeParsedAndDeparsed method. Do not add new failing tests or missing features without a solution please.

  3. Your tests are BEGIN... END blocks and should be supported and working. What exactly is different about your examples please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented May 28, 2022

Copy link
Copy Markdown
Contributor

Please have a look at net/sf/jsqlparser/statement/BlockTest.java. There are Tests on Block Statements already and your additional Tests could go there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rathboma

rathboma commented May 28, 2022

Copy link
Copy Markdown
Contributor Author

Ok, great! I'll add them there. I didn't see the block tests, so thought this might be a real contribution. I'll move them to that file this week (hopefully with a fix)

Matthew
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wumpz
wumpz merged commit c1c38fe into JSQLParser:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rathboma @manticore-projects @wumpz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.