GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add support for postgres drop function statement by rrrship · Pull Request #1557 · JSQLParser/JSqlParser

Conversation

@rrrship

@rrrship rrrship commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Adds a support for PostgreSQL DROP FUNCTION statement: PostgreSQL DROP FUNCTION documentation

Also added a new map to Drop class to store parameters by type. Not sure about other drop types, but drop function actually has a more richer syntax with additional parameters which we could support in the future. Storing them in a map could possibly hold off bloating the class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rrrship
add support for postgres drop function statement
0d6f57b
@manticore-projects

manticore-projects commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Greetings.

Thank you very much for your contribution. It looks great, kudos!
@wumpz: Its high quality content and I would like to recommend speedy adoption.
rrrship reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rrrship
Merge branch 'JSQLParser:master' into master
5816c6a
@rrrship

rrrship commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

Since I'm new to open source development and contribution, I wanted to ask when and how often are the pull requests merged to master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Since I'm new to open source development and contribution, I wanted to ask when and how often are the pull requests merged to master.

Honestly, I do not know either and I am thinking about establishing a "Development Branch", which would merge any pending PRs under a rolling release model.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wumpz
wumpz merged commit 964fa49 into JSQLParser:master Jul 6, 2022
@wumpz

wumpz commented Jul 6, 2022

Copy link
Copy Markdown
Member

@rrrship sorry about the delay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rrrship @manticore-projects @wumpz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.