GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Keywords2: Update whitelisted Keywords by manticore-projects · Pull Request #1653 · JSQLParser/JSqlParser

Conversation

manticore-projects commented Oct 26, 2022

Copy link

Copy Markdown

Contributor

Updates the Keywords in RelObjectNameWithoutValue after PR #1649 introduced new tokens.

Workflow should be like that:

Amend Tokens in the Grammar
When keyword-tests fail, run gradle updateKeywords
Then build via mvn package or gradle build (it does not matter)
Push/Deploy

Using gradle updateKeywords task is optional, you can also add the new Tokens manually has it has always been done before.

After accepting the Keywords PR, any further PR will automatically fail acceptance tests, unless keywords are in order.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

manticore-projects added 30 commits

October 18, 2021 21:41


          Enhanced Keywords

834dab1

Add Keywords and document, which keywords are allowed for what purpose


          Fix incorrect tests

7a885a1


          Merge remote-tracking branch 'origin/master' into Keywords

1b69d25


          Define Reserved Keywords explicitly

5d20d06

Derive All Keywords from Grammar directly
Generate production for Object Names (semi-) automatically
Add parametrized Keyword Tests


          Fix test resources

df9c56e


          Adjust Gradle to JUnit 5

de805ab

Parallel Test execution
Gradle Caching
Explicitly request for latest JavaCC 7.0.10


          Do not mark SpeedTest for concurrent execution

d5a6dca


          Remove unused imports

a9d0503


          Adjust Gradle to JUnit 5

6dfa05f

Parallel Test execution
Gradle Caching
Explicitly request for latest JavaCC 7.0.10


          Do not mark SpeedTest for concurrent execution

8f0bfe6


          Remove unused imports

5cd0974


          Merge remote-tracking branch 'origin/master'

5f11d3f


          Merge remote-tracking branch 'origin/Keywords' into Keywords

2af3cd5


          Merge remote-tracking branch 'origin/master' into Keywords

4bef952

# Conflicts:
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt


          Keyword test adopt JUnit5

1fd56ac

Update keywords


          Merge Master

873dfd4


          CheckStyle sanitation of method names

1a9db26


          Merge https://github.com/JSQLParser/JSqlParser

3ab04b0


          Merge branch 'JSQLParser:master' into master

de94651


          Merge branch 'master' of github.com:JSQLParser/JSqlParser

84709a9


          Merge github.com:JSQLParser/JSqlParser into Keywords

dc3ef91


          Merge Master

0e0662d


          Merge branch 'master' of github.com:JSQLParser/JSqlParser

3c8da30


          Merge branch 'master' into Keywords

cae7a1f

# Conflicts:
#	build.gradle


          Add Jupiter Parameters dependency again

886fe59


          Automate the updateKeywords Step

353edb4


          Update PMD and rules

0ad0b79


          Rewrite test expected to fail

ae46480


          Appease Codacy

74c1f71


          Remove broken rule warning about perfectly fine switch-case statements

ba9992e

manticore-projects added 23 commits

July 18, 2022 08:07


          Merge branch 'master' of github.com:JSQLParser/JSqlParser

6b07f70


          Merge remote-tracking branch 'origin/master' into Keywords

8a8b718

# Conflicts:
#	build.gradle
#	ruleset.xml
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java
#	src/test/java/net/sf/jsqlparser/statement/select/SpecialOracleTest.java


          Merge Upstream

d54c1fb


          Merge remote-tracking branch 'manticore/Keywords' into Keywords

1d89095

# Conflicts:
#	README.md
#	build.gradle
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/statement/select/SpecialOracleTest.java


          Merge Master

ab6f9d5


          Merge github.com:JSQLParser/JSqlParser

39a3476


          Merge Master

61bfb68


          Fixes broken PR JSQLParser#1524 and Commit fb6e950

796893d


          Add AST Visualization

520e1e6

Show the Statement's Java Objects in a tree hierarchy


          Merge branch 'master' of github.com:JSQLParser/JSqlParser

7f4c510


          Merge remote-tracking branch 'origin/master' into Keywords

a4032a2


          Merge branch 'master' into Keywords

08141a3


          Merge branch 'master' of github.com:JSQLParser/JSqlParser into Keywords

c512b8e


          build: temporarily reduce the Code Coverage requirements

0c6f0e4

Temporarily reduce the Coverage checks regarding Minimum Coverage and Maximum Missed Lines in order to get the Keywords PR accepted. We should do a major Code cleanup afterwards.


          Merge remote-tracking branch 'origin/master' into Keywords

6953d8b

# Conflicts:
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt


          merge Master

a8ffe64


          Merge branch 'master' into Keywords

1d4eb9e


          build: JSQLParser is a build dependency

b6146cf


          chore: Update keywords

b07d839


          Merge remote-tracking branch 'manticore/Keywords' into Keywords

1e159ba

# Conflicts:
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt


          feat: add line count to output

b0d6218


          Merge github.com:JSQLParser/JSqlParser into Keywords

03264c7


          Fix: updateKeywords to reflect new tokens

fce5602

wumpz commented Oct 28, 2022

Copy link

Copy Markdown

Member

Since I have accepted those enhanced keywords, why is this pr so large?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

manticore-projects added 2 commits

October 29, 2022 07:41


          test: Keywords enabled 2 more Special Oracle Tests

ca6efc1


          build: add updateKeywords to the Maven Build

5adfc3c

update/cleanup dependencies in Maven and Gradle
add EXEC plugin to Maven for updating white listed keywords in the Grammaer

manticore-projects commented Oct 29, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Since I have accepted those enhanced keywords, why is this pr so large?

It actually changed only 4 Files:

the Grammar, fixing the RelObjectNameWithoutValue() keywords
the Maven Build file, adding a Task for updating the RelObjectNameWithoutValue() keywords and dependencies.
Run the Maven task via

mvn compile exec:java

the Gradle Build file, updating dependencies
Oracle Special Tests, since Keywords enabled 2 more tests

I do not know, why GIT carries all the change set since branching, after I merged MASTER.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

manticore-projects mentioned this pull request

Oct 29, 2022

Enhanced Keywords #1382

Merged

wumpz reviewed

Nov 2, 2022

View reviewed changes

Comment thread

pom.xml Resolved

Uh oh!

There was an error while loading. Please reload this page.

wumpz merged commit f3e04b3 into JSQLParser:master

Nov 2, 2022

Reviewers

wumpz

wumpz left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

manticore-projects commented Oct 26, 2022

Uh oh!

wumpz commented Oct 28, 2022

Uh oh!

manticore-projects commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manticore-projects commented Oct 29, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.