GeezerVison is showing github.com — Unit tests support multi-os and higher versions of jdk by kslex · Pull Request #1886 · JSQLParser/JSqlParser
Conversation
kslex
commented
Nov 8, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
When I run unit tests, there are two failures:
- ParserKeywordsUtilsTest#getAllKeywords failed to run. Because my os is windows and the regex in ParserKeywordsUtils#getAllKeywordsUsingRegex seems not support multi-os.
- Compilation fails when using JDK 17. Nashorn has been deprecated after jdk11 and removed after jdk15.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Greetings!
Thank you for your contribution, especially the fix of the Regex is great.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.