GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add support comment in `create view` for MySQL and MariaDb by jxnu-liguobin · Pull Request #1913 · JSQLParser/JSqlParser

Conversation

@jxnu-liguobin

@jxnu-liguobin jxnu-liguobin commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jxnu-liguobin added 2 commits December 14, 2023 10:43
@jxnu-liguobin
CreateView with comment for mysql
02b6f95
@jxnu-liguobin
Add test
4b84142
@jxnu-liguobin
jxnu-liguobin force-pushed the view-comment branch from 2e723a2 to 4b84142 Compare December 14, 2023 03:01
@jxnu-liguobin jxnu-liguobin changed the title feat: Add support comment in create view for mysql feat: Add support comment in create view for MySQL and mariaDb Dec 14, 2023
@jxnu-liguobin jxnu-liguobin changed the title feat: Add support comment in create view for MySQL and mariaDb feat: Add support comment in create view for MySQL and MariaDb Dec 14, 2023
jxnu-liguobin added 3 commits December 14, 2023 11:52
@jxnu-liguobin
Fix
7cad552
@jxnu-liguobin
Fix
a0a7525
@jxnu-liguobin
Fix
2c88a41
manticore-projects
manticore-projects requested changes Dec 14, 2023
View reviewed changes

@manticore-projects manticore-projects left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
It looks great in general but I wonder if we can reuse the existing Production ColumnDefinition and use an ExpressionList for the collection.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
}
}

ColumnDefinition ColumnDefinitionItem():

@manticore-projects manticore-projects Dec 14, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a similar Production already, please try to re-use it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
}
}

List<ColumnDefinition> ColumnDefinitionItemList():

@manticore-projects manticore-projects Dec 14, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to use an ExpressionList<Column> here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jxnu-liguobin
Fix
72f6d86
@manticore-projects
manticore-projects merged commit 4d47e0a into JSQLParser:master Dec 14, 2023
@manticore-projects

manticore-projects commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Thank you for your very good contribution, we do appreciate!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Please would you still like to fix the Grammar regarding

Warning: Choice conflict in [...] construct at line 1774, column 5.
         Expansion nested within construct and expansion following construct
         have common prefixes, one of which is: "COMMENT"
         Consider using a lookahead of 2 or more for nested expansion.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jxnu-liguobin

jxnu-liguobin commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

COMMENT

ok
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jxnu-liguobin @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.