GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix: [MySQL] Add `COMMENT` for `ALTER ADD` by jxnu-liguobin · Pull Request #1919 · JSQLParser/JSqlParser

Conversation

@jxnu-liguobin

@jxnu-liguobin jxnu-liguobin commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Closed #1906, and format jjt file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jxnu-liguobin added 2 commits December 15, 2023 16:51
@jxnu-liguobin
Closed JSQLParser#1906, Add COMMENT for ALTER ADD and format jjt …
084354f 
…file
@jxnu-liguobin
Closed JSQLParser#1906, Add COMMENT for ALTER ADD and format jjt …
af73c84 
…file
@jxnu-liguobin
jxnu-liguobin marked this pull request as draft December 15, 2023 09:09
@jxnu-liguobin
Fix
bcb1ed4
@manticore-projects

manticore-projects commented Dec 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greetings! Thank you for your work and effort.
I am trying to fix the Gradle based check in parallel to give you prompt feedback on the Q/A.

Can you please PULL from master to benefit from the corrected Actions and Gradle Build file, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jxnu-liguobin

jxnu-liguobin commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

Greetings! Thank you for your work and effort. I am trying to fix the Gradle based check in parallel to give you prompt feedback on the Q/A.

Can you please PULL from master to benefit from the corrected Actions and Gradle Build file, thanks!

ok,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jxnu-liguobin
jxnu-liguobin force-pushed the fix-i1906 branch from 22881f2 to 7a4f664 Compare December 15, 2023 09:56
@jxnu-liguobin
Merge branch 'master' into fix-i1906
77c6005
@jxnu-liguobin
jxnu-liguobin force-pushed the fix-i1906 branch from 7a4f664 to 77c6005 Compare December 15, 2023 10:12
@jxnu-liguobin
jxnu-liguobin marked this pull request as ready for review December 15, 2023 11:46
@manticore-projects
manticore-projects merged commit 262ef55 into JSQLParser:master Dec 15, 2023
@jxnu-liguobin jxnu-liguobin mentioned this pull request Dec 20, 2023
[BUG] 4.8 Snapshot : MySQL : ALTER ADD INDEX , ADD INDEX ;Encountered unexpected token: "comment" "COMMENT" #1926
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] 4.7: MySQL : Alter Add Key Encountered unexpected token: "comment" "COMMENT"

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jxnu-liguobin @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.